-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Red specific app command check decorators #6400
Open
Flame442
wants to merge
7
commits into
Cog-Creators:V3/develop
Choose a base branch
from
Flame442:6017-red-app-command-checks
base: V3/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Red specific app command check decorators #6400
Flame442
wants to merge
7
commits into
Cog-Creators:V3/develop
from
Flame442:6017-red-app-command-checks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: Core - API - App Commands Package
This is related to the `redbot.core.app_commands` package.
Category: Core - API - Bank
This is related to the core Bank API.
Category: Docs - Changelogs
This is related to version changelogs.
Category: Docs - Other
This is related to documentation that doesn't have its dedicated label.
Category: Meta
This is related to the repository maintenance.
High Priority
High priority
Type: Feature
New feature or request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Implements
is_owner
,guildowner
,admin
,mod
,guildowner_or_permissions
,admin_or_permissions
,mod_or_permissions
,can_manage_channel
,admin_or_can_manage_channel
,mod_or_can_manage_channel
,bot_can_manage_channel
,bot_can_react
, andbot_in_a_guild
.Currently, this PR reimplements a lot of utils that were used in
commands.requires
, the source of Red specific text command checks, because of circular import issues and the fact that those versions generally rely on having aContext
object. Not sure how fixable this is.Docs: https://red-discordbot--6400.org.readthedocs.build/en/6400/framework_checks_app_commands.html
Closes #6017
Have the changes in this PR been tested?
Yes