Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typo): event_publiher -> event_publisher #149

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

thedevbirb
Copy link
Contributor

If such PRs are unwanted feel free to close this! Just noticed it while browsing the code

@thedevbirb thedevbirb changed the title chore(typo): event_publiher -> event_publisher chore(typo): event_publiher -> event_publisher Oct 7, 2024
@ltitanb
Copy link
Collaborator

ltitanb commented Oct 7, 2024

Much appreciated thanks!

@ltitanb
Copy link
Collaborator

ltitanb commented Oct 7, 2024

The test is failing because of some false positive serde error, think we dont have every version fully pinned correctly yet. Should be fixed in main if you rebase

@thedevbirb
Copy link
Contributor Author

The test is failing because of some false positive serde error, think we dont have every version fully pinned correctly yet. Should be fixed in main if you rebase

Done it! Thanks for the tip. Now the tests pass on local as well.

@ltitanb ltitanb merged commit a769deb into Commit-Boost:main Oct 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants