feat(signer)!: add proxy keys #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `generate_proxy_keys` endpoint to the Signer API. Modify the signer client accordingly. - add a `.dockerignore` file - remove the need for modules to provide their id in requests. A module's JWT is now solely sufficient to identify the module. * `SigningService` now contains jwt <-> module_id in a bidirectional hashmap - add authentication middleware to the signer service instead of manual auth in the handlers - introduce `ModuleId` and `Jwt` wrapper types around strings to improve semantics (useful after a couple of mishaps with key <-> value directions across the different maps) * see `common::types` - add example proxy key generation request in `da_commit` module - small misc changes - small reformatting
* make `crates::common::signature::random_secret()` infallible * fix flaky test
not needed anymore since JWTs now uniquely identify the module
ltitanb
force-pushed
the
main
branch
2 times, most recently
from
417fda3
to
91137e9
Compare
* also, add `rust-toolchain.toml`
David-Petrov
commented
Aug 6, 2024
ltitanb
reviewed
Aug 6, 2024
David-Petrov
force-pushed
the
feat/proxy-keys
branch
from
f6bbabd
to
35cd9a4
Compare
fbrv
reviewed
Aug 7, 2024
David-Petrov
commented
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick summary:
implement a
generate_proxy_keysendpoint to the Signer API. Modify the signer client accordingly.remove the need for modules to provide their id in requests. A module's JWT is now solely sufficient to identify the module.
SigningServicenow contains jwt <-> module_id in a bidirectional hashmapadd authentication middleware to the signer service instead of manual auth in the handlers
introduce
ModuleIdandJwtwrapper types around strings to improve semantics (useful after a couple of mishaps with key <-> value directions across the different maps + axum's custom type extensions on requests)common::typesadd example proxy key generation request in
da_commitmoduleadd
rust-toolchain.tomladd a
.dockerignorefilesmall misc changes
little reformatting
TODOs
TODOscloses #19