Fix whitespace-related Rubocop warnings across the tree

Fix:
- Extra empty line detected at block body beginning.
- Extra blank line detected.
- Inconsistent indentation detected.
- Operator => should be surrounded by a single space.
...across all Ruby files in the tree. Noop.

Change-Id: I8bff4a836f98ce82a4f855333ce77d44287279ea

Rakefile

@@ -76,7 +76,6 @@ namespace :syntax do
         'syntax:hiera',
         'syntax:templates',
     ]
-
 end
 
 RuboCop::RakeTask.new(:rubocop)
@@ -93,7 +92,6 @@ PuppetLint::RakeTask.new :puppetlint_head do |config|
     config.pattern = git_changed_in_head ['.pp']
 end
 
-
 task :default => [:help]
 
 desc 'Run all build/tests commands (CI entry point)'
@@ -105,7 +103,6 @@ task lint: [:typos, :rubocop, :syntax, :puppetlint]
 desc 'Run all linting commands against HEAD'
 task lint_head: [:typos, :rubocop, :"syntax:head", :puppetlint_head]
 
-
 desc 'Show the help'
 task :help do
     puts "Puppet helper for operations/puppet.git
@@ -121,8 +118,8 @@ Welcome #{ENV['USER']} to WMFs wonderful rake helper to play with puppet.
     # Show our tasks list.
     system "rake -T"
 
-puts "-----------------------------------------------------------------------"
-puts "
+    puts "-----------------------------------------------------------------------"
+    puts "
 Examples:
 
 Validate syntax for all puppet manifests:
@@ -134,7 +131,6 @@ Validate manifests/nfs.pp and manifests/apaches.pp
 Run puppet-lint style checker:
   rake puppetlint
 "
-
 end
 
 desc "Build documentation"
@@ -170,7 +166,6 @@ end
 
 desc "Run spec tests found in modules"
 task :spec do
-
     # Hold a list of modules not passing tests.
     failed_modules = []
     ignored_modules = ['mysql', 'osm', 'puppetdbquery', 'stdlib', 'wdqs']

modules/aptrepo/spec/classes/aptrepo_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'aptrepo', :type => :class do
-
     let(:params) {{ :basedir => '/srv/wikimedia' }}
 
     it { should compile }

modules/aptrepo/spec/classes/distribution_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'aptrepo::distribution', :type => :class do
-
     let(:params) {{
         :basedir => '/srv/wikimedia',
         :settings => {
@@ -21,5 +20,4 @@
             'group'  => 'root',
         })
     end
-
 end

modules/bacula/spec/defines/fileset_spec.rb

@@ -2,7 +2,7 @@
 
 describe 'bacula::director::fileset', :type => :define do
     let(:title) { 'something' }
-    let(:params) { { :includes    => [ "/", "/var", ], } }
+    let(:params) { { :includes => [ "/", "/var", ], } }
 
     it 'should create /etc/bacula/conf.d/fileset-something.conf' do
         should contain_file('/etc/bacula/conf.d/fileset-something.conf').with({
@@ -34,5 +34,4 @@
             .with_content(/File = \/tmp/)
         end
     end
-
 end

modules/base/Rakefile

@@ -14,7 +14,6 @@ symlinks = { 'spec/fixtures/modules/%s/files' % modulename => '../../../../files
   'spec/fixtures/modules/%s/templates' % modulename => '../../../../templates',
 }
 
-
 task :setup do
   FileUtils.mkdir_p('spec/fixtures/modules/%s' % modulename)
   extra_modules.each do |x|

modules/base/files/monitoring/check_puppetrun

@@ -111,7 +111,6 @@ def time_ago(s)
   "Indeterminate amount of time (see time_ago)"
 end
 
-
 if failcount == :failed
     puts "CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues"
     exit 2

modules/base/lib/facter/initsystem.rb

@@ -13,7 +13,6 @@
   confine :kernel => %w{Linux FreeBSD OpenBSD SunOS Darwin GNU/kFreeBSD}
 
   setcode do
-
     if FileTest.exists?("/run/systemd/system")
       # also see sd_booted(3)
       result = "systemd"

modules/base/lib/puppet/parser/functions/pick_initscript.rb

@@ -8,7 +8,7 @@
 available init scripts, and returns the chosen one.
 HEREDOC
 ) do |vals|
-  name, init_system, has_systemd, has_systemd_override, has_upstart, has_sysvinit, strict  = vals
+  name, init_system, has_systemd, has_systemd_override, has_upstart, has_sysvinit, strict = vals
   has_custom = (has_systemd || has_upstart || has_sysvinit)
   # if we don't have custom scripts, we use the system defaults
   return false unless has_custom

modules/base/spec/defines/expose_puppet_certs_spec.rb

@@ -41,5 +41,4 @@
     it { should contain_file('/my/ssl/dir/ssl/cert.pem').with({ 'ensure' => 'absent' }) }
     it { should contain_file('/my/ssl/dir/ssl/server.key').with({ 'ensure' => 'absent' }) }
   end
-
 end

modules/base/spec/defines/service_unit_spec.rb

@@ -33,7 +33,6 @@
         should contain_file('/etc/init.d/nginx').that_notifies('Exec[systemd reload for nginx]').that_notifies('Service[nginx]')
         should contain_exec('systemd reload for nginx').that_comes_before('Service[nginx]')
       end
-
     end
   end
   context 'with refresh false' do
@@ -54,7 +53,6 @@
     it 'should refresh service' do
         should contain_file('/etc/init.d/nginx').that_notifies('Service[nginx]')
     end
-
   end
   context 'with upstart as init' do
     let(:facts) { {:initsystem => 'upstart'} }

modules/base/spec/spec_helper.rb

@@ -2,7 +2,6 @@
 
 fixture_path = File.expand_path(File.join(__FILE__, '..', 'fixtures'))
 
-
 RSpec.configure do |c|
   c.module_path = File.expand_path("../..", File.dirname(__FILE__))
   c.manifest_dir = File.join(fixture_path, 'manifests')

modules/conftool/files/pooler_loop.rb

@@ -4,7 +4,6 @@
 require 'net/http'
 require 'facter'
 
-
 PATH_ROOT = '/usr/local/bin/'
 
 # default values
@@ -107,7 +106,6 @@ def check_pooled_state(ip, port, pool, host, want_pooled)
   end
 end
 
-
 # do the whole procedure args[:cycles] times
 (1..args[:cycles]).each do
   # try to (de)pool the host we are on

modules/elasticsearch/spec/classes/elasticsearch_rspec.rb

@@ -16,5 +16,4 @@
             .with_content(/-XX:\+PrintGCDateStamps$/)
     }
   end
-
 end

modules/elasticsearch/spec/classes/https_rspec.rb

@@ -29,5 +29,4 @@
       should contain_package('nginx-full').with({ 'ensure' => 'absent' })
     end
   end
-
 end

modules/elasticsearch/spec/classes/ship_logs_to_logstash_rspec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'elasticsearch', :type => :class do
-
   describe 'when NOT sending logs to logstash' do
     let(:params) { { :cluster_name  => 'my_cluster_name' } }
     let(:facts) { { :lsbdistrelease => 'ubuntu',

modules/etcd/lib/puppet/type/etcd_role.rb

@@ -14,5 +14,4 @@ def insync?(is)
       is == should
     end
   end
-
 end

modules/ganglia/lib/puppet/parser/functions/ganglia_aggregator_config.rb

@@ -7,7 +7,6 @@ def calc_url(aggregator, ip_octet)
   format('%s:%d', url, port)
 end
 
-
 module Puppet::Parser::Functions
   newfunction(:ganglia_aggregator_config, :type => :rvalue) do |_|
     config = {}

modules/git/spec/defines/user_spec.rb

@@ -7,7 +7,6 @@
 require 'spec_helper'
 
 describe 'git::userconfig', :type => :define do
-
   let(:title) { 'gitconfig' }
 
   context "Setting up user name and email" do
@@ -26,5 +25,4 @@
       .with_content(/email = [email protected]\n/)
     }
   end
-
 end

modules/graphite/spec/functions/configparser_format_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'configparser_format' do
-
   it 'should format hash into ini format' do
     run.with_params({:section => {:param1 => 'value1', :param2 => 'value2'}})
                           .and_return(
@@ -37,5 +36,4 @@
             "param1 = item1,item2\n"\
         )
   end
-
 end

modules/graphite/spec/spec_helper.rb

@@ -2,7 +2,6 @@
 
 fixture_path = File.expand_path(File.join(__FILE__, '..', 'fixtures'))
 
-
 RSpec.configure do |c|
   c.module_path = File.expand_path("../..", File.dirname(__FILE__))
   c.manifest_dir = File.join(fixture_path, 'manifests')

modules/install_server/spec/classes/install_server_dhcp_server_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'install_server::dhcp_server', :type => :class do
-
     it { should compile }
 
     it 'should have isc-dhcp-server' do

modules/install_server/spec/classes/install_server_preseed_server_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'install_server::preseed_server', :type => :class do
-
     it { should compile }
 
     it do

modules/install_server/spec/classes/install_server_tftp_server_spec.rb

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
 describe 'install_server::tftp_server', :type => :class do
-
     it { should compile }
-
     it { should contain_package('atftpd').with_ensure('present') }
 
     it do
@@ -16,10 +14,10 @@
 
     it do
         should contain_file('/srv/tftpboot').with({
-            'mode'   => '0444',
-            'owner'  => 'root',
-            'group'  => 'root',
-            'recurse'  => 'remote',
+            'mode'    => '0444',
+            'owner'   => 'root',
+            'group'   => 'root',
+            'recurse' => 'remote',
         })
     end
 end

modules/install_server/spec/classes/install_server_web_server_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'install_server::web_server', :type => :class do
-
     # Please wmflib.os_version()
     let(:facts) { {
         :lsbdistrelease => '8.5',

modules/mirrors/spec/classes/mirrors_debian_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'mirrors::debian', :type => :class do
-
     it do
         should contain_file('/srv/mirrors/debian').with({
             'ensure' => 'directory',

modules/mirrors/spec/classes/mirrors_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'mirrors', :type => :class do
-
     it { should contain_user('mirror') }
     it { should contain_group('mirror') }
     it { should contain_file('/srv/mirrors') }

modules/mirrors/spec/classes/mirrors_ubuntu_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe 'mirrors::ubuntu', :type => :class do
-
     it do
         should contain_file('/srv/mirrors/ubuntu/').with({
             'ensure' => 'directory',

modules/nrpe/spec/defines/check_spec.rb

@@ -23,5 +23,4 @@
             should_not contain_file('/etc/nagios/nrpe.d/something.cfg')
         end
     end
-
 end

modules/osm/spec/defines/osm_planet_sync_spec.rb

@@ -31,5 +31,4 @@
             it { should contain_file('/usr/local/bin/replicate-osm').with_content(/--input-reader xml/) }
         end
     end
-
 end

modules/postgresql/spec/classes/postgresql_ganglia.rb

@@ -2,7 +2,7 @@
 
 describe 'postgresql::ganglia', :type => :class do
     let(:params) { {
-        :ensure           => 'present',
+        :ensure => 'present',
         }
     }
 
@@ -14,7 +14,7 @@
 
 describe 'postgresql::slave', :type => :class do
     let(:params) { {
-        :ensure           => 'absent',
+        :ensure => 'absent',
         }
     }
 

modules/postgresql/spec/classes/postgresql_slave_spec.rb

@@ -31,7 +31,7 @@
         :ensure           => 'present',
         :master_server    => 'test',
         :replication_pass => 'pass',
-        :root_dir          => '/srv/postgres',
+        :root_dir         => '/srv/postgres',
         }
     }
     let(:facts) { { :lsbdistcodename => 'jessie' } }

modules/puppet_statsd/lib/puppet/reports/statsd.rb

@@ -7,7 +7,6 @@
 Puppet::Reports.register_report(:statsd) do
     desc = 'Send Puppet metrics to StatsD'
 
-
     def load_config
         config_file = File.join Puppet.settings[:confdir], 'statsd.yaml'
         raise Puppet::ParseError, "#{config_file} is missing" unless File.exists? config_file

modules/puppetmaster/files/puppet_ecdsacert.rb

@@ -30,7 +30,6 @@ class PuppetECDSAGenError < StandardError
   asn1_oid: 'prime256v1'
 }
 
-
 Log = Logger.new(STDOUT)
 
 Log.level = Logger::INFO
@@ -39,7 +38,6 @@ class PuppetECDSAGenError < StandardError
   format("%s %-5s (puppet-ecdsacert): %s\n", date_format, severity, msg)
 end
 
-
 # Ecdsa certificates generator class
 # Generates the cert, the CSR, and sends the signing request to the puppetmaster
 class PuppetECDSAGen
@@ -179,7 +177,6 @@ class CertificateAuthority
   end
 end
 
-
 OptionParser.new do |opts|
   opts.banner = "Usage: puppetecdsamanager [-c configfile] [-a SAN1,SAN2] common-name "
   opts.on('-c', '--configfile CONF', 'Location of the config file') do |conf|

modules/scap/spec/types/scap_source_spec.rb

@@ -16,7 +16,6 @@
     end
   end
 
-
   context "Default values" do
     subject do
       resource_class.new(:name => 'test/deploy')