Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Illegal character encoder issue for repo name #28

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

yma96
Copy link
Member

@yma96 yma96 commented Jul 4, 2024

@yma96 yma96 requested review from ligangty and sswguo July 4, 2024 06:52
@sswguo
Copy link
Member

sswguo commented Jul 4, 2024

Will this impact the generic proxy repo query ? I remembered we make encoder for that repo, just confirm. @ruhan1

@ruhan1
Copy link
Contributor

ruhan1 commented Jul 4, 2024

Will this impact the generic proxy repo query ? I remembered we make encoder for that repo, just confirm. @ruhan1

I guess not. generic proxy does not use indy-client. However, should Indy allow spaces in the repo name? I wonder some others places may break if we allow such.

@sswguo
Copy link
Member

sswguo commented Jul 4, 2024

I guess not. generic proxy does not use indy-client. However, should Indy allow spaces in the repo name? I wonder some others places may break if we allow such.

if so, that does not block this PR, we may need to add input validation for repo creation.

LGTM.

@yma96
Copy link
Member Author

yma96 commented Jul 5, 2024

Ok, I'll merge this first.

@yma96 yma96 merged commit e93b35f into Commonjava:main Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants