Update error message #101
Merged
Update error message #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Probably a case to verify the HEAD request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for https://issues.redhat.com/browse/MMENG-4160
The direct error is
Failed to run validation rule: no-pre-existing-paths, Reason: Parallel execution timeout
caused by
org.commonjava.service.promote.validate.PromotionValidationTools.exists(PromotionValidationTools.java:225)
The total timeout is 30 min to run all the paths of a promotion. The method 'exists' sends HEAD requests to content service (main indy). If main indy has problem to respond, the timeout can happen. (btw, The timeout for each content service call is 5 min)
Mainly this is caused by indy being slow to handle the HEAD requests. It may related to MMENG-4141 "Fix the HEAD request to avoid to read the file"
This pr try to add some useful message when unknown error happens.