-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added first pass at ClamAv resources #412
base: main
Are you sure you want to change the base?
Conversation
9c7ec04
to
e06a2af
Compare
Rebased and cleaned up a merge conflict in SLN file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@csharpfritz, Thanks for the contribution.
This PR is in the right way, but some following improvements need to be resolved:
Is there any way to protect ClamAv with a user and password or API key? If yes, we should cover that.
Is there any health API for ClamAv? I see some unfinished work here. If not, please remove the ConnectionStringAvailableEvent
event subscription part.
Is there any .NET client for ClamAv?
We need some tests for the hosting integration, client integration, and an example for usage. You can get help by looking at Meilisearch or Ollma integration tests.
src/CommunityToolkit.Aspire.Hosting.ClamAv/ClamAvBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
/// <summary>clamav/clamav</summary> | ||
public const string Image = "clamav/clamav"; | ||
/// <summary>latest</summary> | ||
public const string Tag = "latest"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have policy to not use latest
tag beacase it's not reliable. Could you use tag in major.minor
or major.minor.patch
format here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update to 1.4.1
Co-authored-by: Alireza Baloochi <[email protected]>
I have not seen a way to do this.
I can look further into this, its not completely clear from their docs at https://github.com/openbridge/clamav
There is, nClam is available and I had started working on a wrapper for that to include OTel interactions
|
/// <returns>A reference to the <see cref="IResourceBuilder{T}"/>.</returns> | ||
public static IResourceBuilder<ClamAvResource> AddClamAv( | ||
this IDistributedApplicationBuilder builder, | ||
string name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string name, | |
[ResourceName] string name, |
Ensures that the analyzer is run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we moved this to the Unshipped file, since we haven't shipped the integration yet.
**Closes #102 **
Adds a new ClamAv anti-malware resource that can be used to scan uploaded files
PR Checklist
Other information