-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hosting.Ngrok - support v2 configuration file with labels #447
base: main
Are you sure you want to change the base?
Hosting.Ngrok - support v2 configuration file with labels #447
Conversation
@programmation I've kicked off a workflow run. Assuming it builds there will be preview NuGet packages available that you can download (or pull from the Azure DevOps feed) to test it out. |
@dotnet-policy-service agree |
Apologies if this isn't the correct way to fix a (tiny) problem in the original PR. |
db3cd20
to
fe9f96e
Compare
…com/programmation/CommunityToolkit-Aspire into feature/ngrok-v2-configuration-file
I'll wait for @esskar to have a review as their the code owner of this integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the code side; thanks.
But edge labels/edge_id are no longer supported; there is no way to get an edge_id from ngrok anymore, instead you acquire a (free) custom domain from them - this was already supported by the integration.
What issue might someone see as a result of edge labels not being supported and using the integration? |
The issue I had (and the reason for the PR) was that although I have a free URL, if I specify the URL in the Aspire config I get an error at ngrok, but if I omit it, ngrok creates a whole new randomised URL, which breaks my mobile test setup. I could not find any documentation at ngrok on how to upgrade from edge labels to whatever they're doing now so I reached out to them for clarification. In the meantime though I needed something to enable me to use the features that I've been using via docker-compose. |
**Closes #446 **
Adds an extra field in
NgrokEndpoint
to store a dictionary of labels that will be applied to the endpoint in the configuration file.Also supports output in
v2
format. Although this is deprecated it appears to be the only documented way to apply labels to anngrok
endpoint.PR Checklist
Other information