Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dapr component schema #460

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Dapr component schema #460

wants to merge 14 commits into from

Conversation

FullStackChef
Copy link
Contributor

Closes #459

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • [] Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@FullStackChef FullStackChef requested review from aaronpowell and removed request for WhitWaldo and paule96 February 9, 2025 07:55
davidfowl
davidfowl reviewed Feb 9, 2025
View reviewed changes
src/CommunityToolkit.Aspire.Hosting.Dapr/DaprDistributedApplicationLifecycleHook.cs
return await contentWriter(content).ConfigureAwait(false);
}

private string GetAppHostRelativePath(string componentName)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside, we're creating a place to store things like this in 9.1, the aspire store.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice -Apphost relative? wanna point me to the code and I could update inline with that?

@FullStackChef FullStackChef mentioned this pull request Feb 9, 2025
Open
@paule96
Copy link

paule96 commented Feb 10, 2025

Maybe if it is not to big of a no scope of this PR we should already start deviding dapr sidecar and component lifecycles to make our lifes easier later.

So that we would have two LifecycleHooks and that everytime you have something like WithReference on a sidecare you wait for this resource to complete.

With this we will have an easier life if we need to consider the endpoints to generate the correct YAML files

@FullStackChef
Copy link
Contributor Author

@paule96 my preference would be not to increase the scope of the my PR and I think the concept of separating lifecycle hooks needs further thought /design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl left review comments

@aaronpowell aaronpowell Awaiting requested review from aaronpowell

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define Dapr Component Schema Model & WithMetadata Extension Method
3 participants
@FullStackChef @paule96 @davidfowl