[DataTable] Update to release dependencies and fix Padding value for Sizer in DataColumn #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-hawker
added
bug 🐛
michael-hawker
changed the title
niels9001
approved these changes
Dec 1, 2023
|
Thanks @niels9001, @Arlodotexe mind looking at the dependent CommunityToolkit/Tooling-Windows-Submodule#159 and then I can update the pointer here after to main. |
Arlodotexe
approved these changes
Dec 4, 2023
michael-hawker
force-pushed
the
llama/datatable-fix-sizer
branch
from
247b197
to
4ce170e
Compare
|
Alright, updated to the latest tooling main now that that's been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple update to fix issue with DataColumn sizer display (and update to the latest dependencies)
Before, Sizer was invisible, could tell it was there from hover effect though:
After, Sizer appears again:
Tested on UWP and WASDK
Forgot that I don't have to update a Version field anymore, woot! 🎉 (though guess it means it respits out all the packages still...)
Note requires update to sub-module as we weren't on latest package versions of shipped 8.0. Think there was an issue/discussion mentioning this somewhere as well? FYI @Arlodotexe