Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to Build-Toolkit-Docs.ps1 #181

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

Arlodotexe
Copy link
Member

This PR contains two fixes applied to ./Build-Toolkit-Docs.ps1 made while putting together this PR.

See commits for list of full changes.

@michael-hawker
Copy link
Member

@Arlodotexe not sure why the build would have failed on this as we don't reference it...?

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Mar 29, 2024

@Arlodotexe not sure why the build would have failed on this as we don't reference it...?

Looks like it was .NET Native:

"D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\CiTestExp.sln" (default target) (1:2) ->
"D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Uwp\CiTestExp.Uwp.csproj" (default target) (4:6) ->
(BuildNativePackage target) -> 
  C:\Program Files (x86)\Microsoft SDKs\UWPNuGetPackages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): error : Internal compiler error: Object reference not set to an instance of an object. [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Uwp\CiTestExp.Uwp.csproj]

    19 Warning(s)
    1 Error(s)

Rerunning

@Arlodotexe Arlodotexe enabled auto-merge (rebase) April 11, 2024 20:42
@Arlodotexe Arlodotexe added bug 🐛 Something isn't working documentation 📃 Improvements or additions to documentation dev loop ➰ For issues that impact the core dev-loop of building experiments labels Apr 11, 2024
@Arlodotexe Arlodotexe merged commit 065959a into main Apr 11, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/build-scripts/docs branch April 11, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dev loop ➰ For issues that impact the core dev-loop of building experiments documentation 📃 Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants