Fix a Renderer problem related to markdown table #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
Arlodotexe
approved these changes
Jul 11, 2024
michael-hawker
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a problem when using the Community Toolkit: it seems that the markdown format table wasn't rendered correctly. In the YAML-Markdown:
the Code behind
.\CommunityToolkit.App.Shared\Renderers\ToolkitDocumentationRenderer.xaml.cswasn't correct when discarding the YAML part. It uses delimiter "---" so the table was teared apart while parsing.to fix this, modified the parse function for discarding YAML part while not affecting markdown content below.
All markdown files in main repo (components/Extensions/samples) have been examined, and no other problems or breaks were found. The fix was tested using the CommunityToolkit.App.Uwp (Universal Windows) application, and it rendered the tables correctly.
Before:
After:
No other incompatibility or effects have been spotted when testing myself.