Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Build-Toolkit-Gallery script not working in Labs #199

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Jul 17, 2024

Change is needed because certain controls (SettingsControls, Converters) are required for the gallery head and are manually inserted if not provided when building the gallery. In labs, these are referenced via nuget packages and not the csproj, so we skip generating project references for these components.

@Arlodotexe Arlodotexe changed the title Fixed an issue where Build-Toolkit-Gallery script wasn't working in Labs Fixed Build-Toolkit-Gallery script not working in Labs Jul 17, 2024
Copy link

@jazzfae jazzfae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have if, no if, code won't load properly.

@Arlodotexe Arlodotexe merged commit 7d5d479 into main Aug 19, 2024
8 checks passed
@Arlodotexe Arlodotexe deleted the fix/build-scripts/gallery/labs branch August 19, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants