Merge branch 'main' into tests/diagnostics

.devcontainer/Dockerfile

@@ -1,8 +1,5 @@
-# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.208.0/containers/dotnet/.devcontainer/base.Dockerfile
-
-# [Choice] .NET version: 6.0, 5.0, 3.1, 6.0-bullseye, 5.0-bullseye, 3.1-bullseye, 6.0-focal, 5.0-focal, 3.1-focal
-ARG VARIANT="6.0-bullseye-slim"
-FROM mcr.microsoft.com/vscode/devcontainers/dotnet:0-${VARIANT}
+# See https://github.com/devcontainers/images/tree/main/src/dotnet for image choices
+FROM mcr.microsoft.com/vscode/devcontainers/dotnet:8.0
 
 # [Choice] Node.js version: none, lts/*, 16, 14, 12, 10
 ARG NODE_VERSION="none"

.github/workflows/build.yml

@@ -8,9 +8,9 @@ name: CI
 on:
   # Triggers the workflow on push or pull request events but only for the main or release branches
   push:
-    branches: [ main, 'rel/*' ]
+    branches: [ main, 'rel/*', 'dev/*' ]
   pull_request:
-    branches: [ main ]
+    branches: [ main, 'dev/*' ]
 
   # Allows you to run this workflow manually from the Actions tab
   workflow_dispatch:
@@ -269,9 +269,19 @@ jobs:
         with:
           vs-version: '[17.9,)'
 
+      - name: Define excluded MultiTargets (WinUI 2)
+        if: ${{ matrix.winui == '2' }}
+        run: |
+          echo "EXCLUDED_MULTITARGETS=wasdk" >> $env:GITHUB_ENV
+
+      - name: Define excluded MultiTargets (WinUI 3)
+        if: ${{ matrix.winui == '3' }}
+        run: |
+          echo "EXCLUDED_MULTITARGETS=uwp" >> $env:GITHUB_ENV
+
       # Build and pack component nupkg
       - name: Build and pack component packages
-        run: ./tooling/Build-Toolkit-Components.ps1 -MultiTargets all -WinUIMajorVersion ${{ matrix.winui }} -DateForVersion ${{ env.VERSION_DATE }} ${{ env.VERSION_PROPERTY != '' && format('-PreviewVersion "{0}"', env.VERSION_PROPERTY) || '' }} ${{ env.ENABLE_DIAGNOSTICS == 'true' && '-EnableBinlogs' || '' }} ${{ env.ENABLE_DIAGNOSTICS == 'true' && '-Verbose' || '' }} -BinlogOutput ./ -NupkgOutput ./ -Release
+        run: ./tooling/Build-Toolkit-Components.ps1 -MultiTargets all -ExcludeMultiTargets ${{ env.EXCLUDED_MULTITARGETS }} -WinUIMajorVersion ${{ matrix.winui }} -DateForVersion ${{ env.VERSION_DATE }} ${{ env.VERSION_PROPERTY != '' && format('-PreviewVersion "{0}"', env.VERSION_PROPERTY) || '' }} ${{ env.ENABLE_DIAGNOSTICS == 'true' && '-EnableBinlogs' || '' }} ${{ env.ENABLE_DIAGNOSTICS == 'true' && '-Verbose' || '' }} -BinlogOutput ./ -NupkgOutput ./ -Release
 
       # Push Pull Request Packages to our DevOps Artifacts Feed (see nuget.config)
       - name: Push Pull Request Packages (if not fork)

components/Animations/src/Expressions/ExpressionNodes/BooleanNode.cs

@@ -10,7 +10,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class BooleanNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ExpressionNode" />
-public sealed class BooleanNode : ExpressionNode
+public sealed partial class BooleanNode : ExpressionNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="BooleanNode"/> class.

components/Animations/src/Expressions/ExpressionNodes/ColorNode.cs

@@ -12,7 +12,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class ColorNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ExpressionNode" />
-public sealed class ColorNode : ExpressionNode
+public sealed partial class ColorNode : ExpressionNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="ColorNode"/> class.

components/Animations/src/Expressions/ExpressionNodes/Matrix3x2Node.cs

@@ -13,7 +13,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class Matrix3x2Node. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ExpressionNode" />
-public sealed class Matrix3x2Node : ExpressionNode
+public sealed partial class Matrix3x2Node : ExpressionNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="Matrix3x2Node"/> class.

components/Animations/src/Expressions/ExpressionNodes/QuaternionNode.cs

@@ -12,7 +12,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class QuaternionNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref=CommunityToolkit.WinUI.Animations.Expressions.ExpressionNode" />
-public sealed class QuaternionNode : ExpressionNode
+public sealed partial class QuaternionNode : ExpressionNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="QuaternionNode"/> class.

components/Animations/src/Expressions/ExpressionNodes/ScalarNode.cs

@@ -10,7 +10,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class ScalarNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ExpressionNode" />
-public sealed class ScalarNode : ExpressionNode
+public sealed partial class ScalarNode : ExpressionNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="ScalarNode"/> class.

components/Animations/src/Expressions/ExpressionNodes/Vector2Node.cs

@@ -12,7 +12,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class Vector2Node. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ExpressionNode" />
-public sealed class Vector2Node : ExpressionNode
+public sealed partial class Vector2Node : ExpressionNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="Vector2Node"/> class.

components/Animations/src/Expressions/ExpressionNodes/Vector3Node.cs

@@ -12,7 +12,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class Vector3Node. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ExpressionNode" />
-public sealed class Vector3Node : ExpressionNode
+public sealed partial class Vector3Node : ExpressionNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="Vector3Node"/> class.

components/Animations/src/Expressions/ExpressionNodes/Vector4Node.cs

@@ -12,7 +12,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class Vector4Node. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ExpressionNode" />
-public sealed class Vector4Node : ExpressionNode
+public sealed partial class Vector4Node : ExpressionNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="Vector4Node"/> class.

components/Animations/src/Expressions/ReferenceNodes/AmbientLightReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class AmbientLightReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="ReferenceNode" />
-public sealed class AmbientLightReferenceNode : ReferenceNode
+public sealed partial class AmbientLightReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="AmbientLightReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/ColorBrushReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class ColorBrushReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ReferenceNode" />
-public sealed class ColorBrushReferenceNode : ReferenceNode
+public sealed partial class ColorBrushReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="ColorBrushReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/DistantLightReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class DistantLightReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ReferenceNode" />
-public sealed class DistantLightReferenceNode : ReferenceNode
+public sealed partial class DistantLightReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="DistantLightReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/DropShadowReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class DropShadowReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ReferenceNode" />
-public sealed class DropShadowReferenceNode : ReferenceNode
+public sealed partial class DropShadowReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="DropShadowReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/InsetClipReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class InsetClipReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ReferenceNode" />
-public sealed class InsetClipReferenceNode : ReferenceNode
+public sealed partial class InsetClipReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="InsetClipReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/InteractionTrackerReferenceNode.cs

@@ -16,7 +16,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class InteractionTrackerReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ReferenceNode" />
-public sealed class InteractionTrackerReferenceNode : ReferenceNode
+public sealed partial class InteractionTrackerReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="InteractionTrackerReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/ManipulationPropertySetReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class ManipulationPropertySetReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.PropertySetReferenceNode" />
-public sealed class ManipulationPropertySetReferenceNode : PropertySetReferenceNode
+public sealed partial class ManipulationPropertySetReferenceNode : PropertySetReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="ManipulationPropertySetReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/NineGridBrushReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class NineGridBrushReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ReferenceNode" />
-public sealed class NineGridBrushReferenceNode : ReferenceNode
+public sealed partial class NineGridBrushReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="NineGridBrushReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/PointLightReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class PointLightReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ReferenceNode" />
-public sealed class PointLightReferenceNode : ReferenceNode
+public sealed partial class PointLightReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="PointLightReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/PointerPositionPropertySetReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class PointerPositionPropertySetReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.PropertySetReferenceNode" />
-public sealed class PointerPositionPropertySetReferenceNode : PropertySetReferenceNode
+public sealed partial class PointerPositionPropertySetReferenceNode : PropertySetReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="PointerPositionPropertySetReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/PropertySetReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class PropertySetReferenceNode.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ReferenceNode" />
-public class PropertySetReferenceNode : ReferenceNode
+public partial class PropertySetReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="PropertySetReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/SpotLightReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class SpotLightReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ReferenceNode" />
-public sealed class SpotLightReferenceNode : ReferenceNode
+public sealed partial class SpotLightReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="SpotLightReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/SurfaceBrushReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class SurfaceBrushReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ReferenceNode" />
-public sealed class SurfaceBrushReferenceNode : ReferenceNode
+public sealed partial class SurfaceBrushReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="SurfaceBrushReferenceNode"/> class.

components/Animations/src/Expressions/ReferenceNodes/VisualReferenceNode.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Animations.Expressions;
 /// Class VisualReferenceNode. This class cannot be inherited.
 /// </summary>
 /// <seealso cref="CommunityToolkit.WinUI.Animations.Expressions.ReferenceNode" />
-public sealed class VisualReferenceNode : ReferenceNode
+public sealed partial class VisualReferenceNode : ReferenceNode
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="VisualReferenceNode" /> class.

components/Behaviors/src/FocusTargetList.cs

@@ -7,6 +7,6 @@ namespace CommunityToolkit.WinUI.Behaviors;
 /// <summary>
 /// A collection of <see cref="FocusTarget"/>.
 /// </summary>
-public sealed class FocusTargetList : List<FocusTarget>
+public sealed partial class FocusTargetList : List<FocusTarget>
 {
 }

components/Collections/src/AdvancedCollectionView/AdvancedCollectionView.Defer.cs

@@ -22,7 +22,7 @@ public IDisposable DeferRefresh()
     /// Notification deferrer helper class
     /// </summary>
 #pragma warning disable CA1063 // Implement IDisposable Correctly
-    public class NotificationDeferrer : IDisposable
+    public partial class NotificationDeferrer : IDisposable
 #pragma warning restore CA1063 // Implement IDisposable Correctly
     {
         private readonly AdvancedCollectionView _acvs;

components/Helpers/src/CameraHelper/CameraHelper.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Helpers;
 /// Make sure you have the capability webcam enabled for your app to access the device's camera.
 /// </summary>
 #pragma warning disable CA1063 // Implement IDisposable Correctly
-public class CameraHelper : IDisposable
+public partial class CameraHelper : IDisposable
 {
     private static IReadOnlyList<MediaFrameSourceGroup>? _frameSourceGroups;
 #pragma warning disable CA2213 // Disposable fields should be disposed

components/Helpers/src/ThemeListener.cs

@@ -26,7 +26,7 @@ namespace CommunityToolkit.WinUI.Helpers;
 /// and Signals an Event when they occur.
 /// </summary>
 [AllowForWeb]
-public sealed class ThemeListener : IDisposable
+public sealed partial class ThemeListener : IDisposable
 {
     /// <summary>
     /// Gets the Name of the Current Theme.

components/Media/src/Extensions/System.Threading.Tasks/AsyncMutex.cs

@@ -10,7 +10,9 @@ namespace CommunityToolkit.WinUI.Media;
 /// An <see langword="async"/> <see cref="AsyncMutex"/> implementation that can be easily used inside a <see langword="using"/> block
 /// </summary>
 #pragma warning disable CA1001 // Types that own disposable fields should be disposable
+#pragma warning disable CsWinRT1028 // Partial not required for types never passed to native WinRT method.
 internal sealed class AsyncMutex
+#pragma warning restore CsWinRT1028
 #pragma warning restore CA1001 // Types that own disposable fields should be disposable
 {
     /// <summary>
@@ -32,7 +34,9 @@ public async Task<IDisposable> LockAsync()
     /// <summary>
     /// Private class that implements the automatic release of the semaphore
     /// </summary>
+#pragma warning disable CsWinRT1028 // Partial not required for types never passed to native WinRT method.
     private sealed class Lock : IDisposable
+#pragma warning restore CsWinRT1028
     {
         /// <summary>
         /// The <see cref="SemaphoreSlim"/> instance of the parent class

components/Primitives/src/StaggeredLayout/StaggeredColumnLayout.cs

@@ -5,7 +5,7 @@
 namespace CommunityToolkit.WinUI.Controls;
 
 [DebuggerDisplay("Count = {Count}, Height = {Height}")]
-internal class StaggeredColumnLayout : List<StaggeredItem>
+internal partial class StaggeredColumnLayout : List<StaggeredItem>
 {
     public double Height { get; private set; }
 

components/RangeSelector/src/RangeSelector.Input.Drag.cs

@@ -77,7 +77,7 @@ private double DragThumb(Thumb? thumb, double min, double max, double nextPos)
 
         Canvas.SetLeft(thumb, nextPos);
 
-        if (_toolTipText != null && _toolTip != null && thumb != null)
+        if (_toolTip != null && thumb != null)
         {
             var thumbCenter = nextPos + (thumb.Width / 2);
             _toolTip.Measure(new Size(double.PositiveInfinity, double.PositiveInfinity));
@@ -99,15 +99,16 @@ private void Thumb_DragStarted(Thumb thumb)
         Canvas.SetZIndex(otherThumb, 0);
         _oldValue = RangeStart;
 
-        if (_toolTipText != null && _toolTip != null)
+        if (_toolTip != null)
         {
             _toolTip.Visibility = Visibility.Visible;
             var thumbCenter = _absolutePosition + (thumb.Width / 2);
             _toolTip.Measure(new Size(double.PositiveInfinity, double.PositiveInfinity));
             var ttWidth = _toolTip.ActualWidth / 2;
             Canvas.SetLeft(_toolTip, thumbCenter - ttWidth);
 
-            UpdateToolTipText(this, _toolTipText, useMin ? RangeStart : RangeEnd);
+            if (_toolTipText != null)
+                UpdateToolTipText(this, _toolTipText, useMin ? RangeStart : RangeEnd);
         }
 
         VisualStateManager.GoToState(this, useMin ? MinPressedState : MaxPressedState, true);

components/RichSuggestBox/src/RichSuggestToken.cs

@@ -13,7 +13,7 @@ namespace CommunityToolkit.WinUI.Controls;
 /// <summary>
 /// RichSuggestToken describes a suggestion token in the document.
 /// </summary>
-public class RichSuggestToken : INotifyPropertyChanged
+public partial class RichSuggestToken : INotifyPropertyChanged
 {
     /// <inheritdoc/>
     public event PropertyChangedEventHandler? PropertyChanged;

components/SettingsControls/src/Helpers/StyleExtensions.cs

@@ -8,7 +8,7 @@ namespace CommunityToolkit.WinUI.Controls;
 public static partial class StyleExtensions
 {
     // Used to distinct normal ResourceDictionary and the one we add.
-    private sealed class StyleExtensionResourceDictionary : ResourceDictionary
+    private sealed partial class StyleExtensionResourceDictionary : ResourceDictionary
     {
     }
 

components/TokenizingTextBox/src/InterspersedObservableCollection.cs

@@ -14,7 +14,7 @@ namespace CommunityToolkit.WinUI.Controls;
 #pragma warning disable CS8622
 #pragma warning disable CS8603
 #pragma warning disable CS8714
-internal class InterspersedObservableCollection : IList, IEnumerable<object>, INotifyCollectionChanged
+internal partial class InterspersedObservableCollection : IList, IEnumerable<object>, INotifyCollectionChanged
 {
     public IList ItemsSource { get; private set; }