Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiTarget Matrix for CI, support for solution generation #456

Merged
merged 19 commits into from
Aug 2, 2024

Conversation

Arlodotexe
Copy link
Member

This PR

  • Updates tooling with the latest fixes and improvements to multitarget support for solution generation
  • Refactors the build job, splitting into build and package.
    • The build job is matrixed in line with the multitarget system
    • The package job is not matrixed and has been refactored to use our ./tooling/Build-Toolkit-Components.ps1 script.

Prerequisite PR: CommunityToolkit/Tooling-Windows-Submodule#200

@Arlodotexe
Copy link
Member Author

Labs will need the same build.yml treatment as well.

@michael-hawker
Copy link
Member

Weird actual test failure:

 Failed Test_RichSuggestBox_AddTokens (@Token1,@Token2,@Token3) [434 ms]
  Error Message:
   Assert.IsTrue failed. SuggestionChosen was not invoked.
  Stack Trace:
     at RichSuggestBoxExperiment.Tests.Test_RichSuggestBox.TestAddTokenAsync(RichSuggestBox rsb, String tokenText) in C:\a\Windows\Windows\components\RichSuggestBox\tests\Test_RichSuggestBox.cs:line 354
   at RichSuggestBoxExperiment.Tests.Test_RichSuggestBox.<>c__DisplayClass0_0.<<Test_RichSuggestBox_AddTokens>b__0>d.MoveNext() in C:\a\Windows\Windows\components\RichSuggestBox\tests\Test_RichSuggestBox.cs:line 33
--- End of stack trace from previous location ---
   at CommunityToolkit.WinUI.DispatcherQueueExtensions.<>c__DisplayClass3_0.<<EnqueueAsync>b__1>d.MoveNext() in /_/components/Extensions/src/Dispatcher/DispatcherQueueExtensions.cs:line 180
--- End of stack trace from previous location ---
   at RichSuggestBoxExperiment.Tests.Test_RichSuggestBox.Test_RichSuggestBox_AddTokens(String tokenText1, String tokenText2, String tokenText3) in C:\a\Windows\Windows\components\RichSuggestBox\tests\Test_RichSuggestBox.cs:line 26
   at Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.ThreadOperations.ExecuteWithAbortSafety(Action action)

@Arlodotexe
Copy link
Member Author

Weird actual test failure:

Seems to be #347, rekicking.

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just wondering if we can "simplify" some of the re-use between the jobs?

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
It should have output the *.nupkg for all packages to the path ./ we passed into the build script, but the ./*.nupkg wildcard failed to find them for artifact upload.

Either our script copies nupkg to the given folder locally but not in CI, or `dotnet nuget push ./*.nupkg` failed to locate nupkg files output to the working directory. Let's see which one.
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Aug 1, 2024

@michael-hawker Looks like the package step ran successfully, but the CI is still expecting status checks on build (WinUI2) and build (WinUI3), which were refactored into the matrix in this PR. Are these set in repo settings?

@michael-hawker
Copy link
Member

@michael-hawker Looks like the package step ran successfully, but the CI is still expecting status checks on build (WinUI2) and build (WinUI3), which were refactored into the matrix in this PR. Are these set in repo settings?

Yeah, these are settings in the repo, we all set to go then? I can switch them over.

@Arlodotexe Arlodotexe enabled auto-merge (rebase) August 1, 2024 22:56
@Arlodotexe Arlodotexe merged commit 9c7642f into main Aug 2, 2024
22 of 23 checks passed
@Arlodotexe Arlodotexe deleted the ci/multitarget-matrix branch August 2, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants