Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property TextAlignment in DataGridTextColumn to support align the text in rows to right #4281

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

quangtrang1111
Copy link

Fixes

Fixes #4276

I add optional property named TextAlignment in the class DataGridTextColumn.

PR Type

Feature

What is the current behavior?

Currently, I cannot align the text in DataGridTextColumn to right.

What is the new behavior?

With the new optional property name TextAlignment we can align the text in rows.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Here is the result after I implemented TextAlignment
image

@ghost
Copy link

ghost commented Sep 28, 2021

Thanks quangtrang1111 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Rosuavio September 28, 2021 03:42
@ghost ghost added the feature request 📬 A request for new changes to improve functionality label Sep 28, 2021
@XAML-Knight
Copy link
Contributor

Hi @quangtrang1111, looks pretty good so far. Have you attempted to expose text alignment as a dependency property (much like FontFamily), so our users can more easily set this value in the XAML?

@quangtrang1111
Copy link
Author

Thanks for your suggestion @XAML-Knight. I made TextAlignment as a dependency property.

@michael-hawker michael-hawker removed the request for review from Rosuavio August 26, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 📬 A request for new changes to improve functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support TextAlignment in DataGridTextColumn to allow align the text in rows to right
3 participants