Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enforce insert issue number unit tests #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Anarcroth
Copy link
Contributor

Sorry for the delay. Let me know what you think about this :) I'm ready to make any changes.

@Anarcroth Anarcroth force-pushed the feature/add-enforce-insert-issue-number-unit-tests branch from eae61bc to 90f510a Compare October 14, 2019 10:44
@Anarcroth Anarcroth force-pushed the feature/add-enforce-insert-issue-number-unit-tests branch from 90f510a to 2626783 Compare October 14, 2019 10:51
@CompSciLauren
Copy link
Owner

Hey! First off, thank you so much for taking the time to write these tests!

So I like what you have here, but I'm having a hard time getting it to work on Travis CI. The build seems to fail because these tests depend on the enforce-insert-issue-number hook being enabled on the repo, and I don't think we can directly rely on that for any tests. Since we need everything to pass on Travis CI, I don't feel comfortable merging this until we figure out how to make Travis CI build successfully.

I spent a lot of time looking into this today but I wasn't able to get it resolved. Unfortunately, I'm about to be really busy for the next couple of weeks and I can't look at this in detail again until roughly Nov 1st - 3rd. Very sorry about that. Please let me know if any of that isn't quite clear or if you have questions. In the meantime, feel free to look into this if you have time, and I'll definitely be looking at this more when I can!

@Anarcroth
Copy link
Contributor Author

Heyo, no worries, I understand. I was having trouble with passing the build as well. I will try to redo the tests so that the build passes and they don't rely on the repo :)

@zackse
Copy link
Contributor

zackse commented Oct 28, 2019

One approach is something like 68793f5 where we install the hook during @setup and restore the original (if any) during @teardown.

It's not the most elegant, and there is some repetition, but it's a start.

FWIW, the travis build does pass when using this approach. https://travis-ci.org/zackse/awesome-git-hooks/builds/603996943 is a sample build that has the equivalent of PRs #28, #29, #30, and #32 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants