Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s image content from PRs: remove token from action parameters #11608

Merged

Conversation

yuumasato
Copy link
Member

Description:

  • Remove github-token from the Upsert comment on the PR job.

Rationale:

Review Hints:

  • Needs to be merged to take effect.
  • The workflow_run always executes what is on the master branch.

It seems that the default value of `${{ github.token }}` is enough.
@yuumasato yuumasato added the OpenShift OpenShift product related. label Feb 19, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11608

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11608

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11608 make deploy-local

Copy link

codeclimate bot commented Feb 19, 2024

Code Climate has analyzed commit 88f71d6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd merged commit 6cdfb87 into ComplianceAsCode:master Feb 21, 2024
44 checks passed
@yuumasato yuumasato deleted the remove_github_token_upsert_comment branch February 22, 2024 16:51
@Mab879 Mab879 added the Infrastructure Our content build system label May 16, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants