-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more precise URI for SRG CTR #11647
Add more precise URI for SRG CTR #11647
Conversation
Update SRG CTR reference to a more specific URI. The application-servers is about Apache, JBoss and other server applications.
Run test_product_stability.py --update-reference-data and update product stability data.
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit 543d2fc and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.8% (0.0% change). View more on Code Climate. |
/hold for test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
/hold for test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@yuumasato Just one question: I verified with command
|
/unhold |
@xiaojiey correct , no new CRDs are expected. |
I have folded these commits into #11593. The STIG ID URI required updates as well, so I decide to merge these PRs, as they are both touching similar code and require updates to the product stability data. |
Description:
SRG-APP-XXXXXX-CTR-XXXXXX
references:container-platform
app-srg-ctr
reference URI.test_product_stability.py --update-reference-data
Rationale:
container-platform
URI more accurately points to the source of SRG CTR.Review Hints:
ocp4
andrhcos4
and check that theSRG-APP-XXXXXX-CTR-XXXXX
references havehref
pointing tohttps://public.cyber.mil/stigs/downloads/?_dl_facet_stigs=container-platform