Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openembedded fixes #11652

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

sarnold
Copy link
Contributor

@sarnold sarnold commented Mar 5, 2024

Description:

  • post-test cleanup for initial openembedded profile(s) and a package name override

Rationale:

  • align profiles with crypto-policy package recipe availability
  • fix an error in the banner selector vars
  • allow login_defs rule to pass

Review Hints:

  • Nothing special, changes are small-ish

* remove duplicate selector and crypto-policy rules from standard profile
* add expanded profile with crypto-policy and more network rules

Note there are no crypto-policy recipes in available bitbake layers yet.

Signed-off-by: Steve Arnold <[email protected]>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Mar 5, 2024
Copy link

openshift-ci bot commented Mar 5, 2024

Hi @sarnold. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented Mar 5, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Mar 5, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11652
This image was built from commit: 9ba2d33

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11652

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11652 make deploy-local

* start collecting package name overrdies in package.yml

Signed-off-by: Stephen L Arnold <[email protected]>
Copy link

codeclimate bot commented Mar 6, 2024

Code Climate has analyzed commit 9ba2d33 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.8% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added New Profile Issues or pull requests related to new Profiles. Update Profile Issues or pull requests related to Profiles updates. labels Mar 6, 2024
@marcusburghardt marcusburghardt added this to the 0.1.73 milestone Mar 6, 2024
@marcusburghardt marcusburghardt self-assigned this Mar 6, 2024
@marcusburghardt marcusburghardt merged commit b22848d into ComplianceAsCode:master Mar 6, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. New Profile Issues or pull requests related to new Profiles. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants