-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust how add_kubernetes_rule.py
determines template filepath
#12068
Conversation
CC: @ermeratos |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Depending on the OpenShift resource being checked, `oc` comamnd may make multiple requests. So let's use the last request sent to determine the url of the resource.
78486d8
to
53babf2
Compare
Code Climate has analyzed commit 53babf2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
@yuumasato In my test, it always complaining format issue of the rule generated by |
@yuumasato: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ping |
Hi. There is no activity in this PR for a long period of time, therefore, I'm closing the PR. If you still want to work on this PR, please feel free to reopen it. Thank you. |
Description:
utils/add_kubernetes_rule.py
determines the resoucesfilepath
.oc
makes multiple requests.Rationale:
oc
comamnd may make multiple requests.So let's use the last request sent to determine the url of the resource.
Review Hints:
./utils/add_kubernetes_rule.py create platform --rule test --name cluster-kube-descheduler-operator --namespace descheduler-operator --type subscriptions.operators.coreos.com --title "test" --description "test" --match-entity "at least one" --yamlpath '.status.installedCSV' --match "clusterkubedescheduleroperator.*" --regex