Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crypto policy in CIS test scenario #12098

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Jun 27, 2024

Description:

Fix for failing Automatus test scenarios:

  • fail: configure_crypto_policy/policy_default_cis_l1.pass (profile:cis_server_l1)
  • fail: configure_crypto_policy/policy_default_cis_l1.pass (profile:cis_workstation_l1)

Rationale:

Related to 96ceda9

Review Hints:

$ python3 tests/automatus.py rule --datastream build/ssg-rhel9-ds.xml --libvirt qemu:///session test-suite-rhel9 --no-reports --scenarios policy_default_cis_l1 configure_crypto_policy

@mildas mildas added RHEL9 Red Hat Enterprise Linux 9 product related. Test Suite Update in Test Suite. CIS CIS Benchmark related. labels Jun 27, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jun 27, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12098
This image was built from commit: 9320bdc

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12098

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12098 make deploy-local

@Mab879 Mab879 self-assigned this Jun 27, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase once #12102 is merged that should resolve the TF issues.

Copy link

codeclimate bot commented Jun 28, 2024

Code Climate has analyzed commit 9320bdc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks.

@Mab879 Mab879 merged commit e72db61 into ComplianceAsCode:master Jun 28, 2024
90 of 93 checks passed
@mildas mildas deleted the fix_cis_automatus branch July 17, 2024 12:47
@Mab879 Mab879 added this to the 0.1.75 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. RHEL9 Red Hat Enterprise Linux 9 product related. Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants