Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to build per rule playbook via build_product script #12105

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Jun 28, 2024

Description:

CMake has an option to build playbooks for each individual rule. Propagate the option also to build_product script.

Rationale:

Useful for testing of individual rule playbooks (e.g. syntax check of each individual rule playbook).

Review Hints:

./build_product rhel9 --playbook-per-rule
check cmake settings:

-- Ansible Playbooks Per Rule: ON

and then check existence of build/rhel9/playbooks/.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12105
This image was built from commit: b6d8f63

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12105

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12105 make deploy-local

Copy link

codeclimate bot commented Jun 28, 2024

Code Climate has analyzed commit b6d8f63 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Jun 28, 2024
@jan-cerny jan-cerny added this to the 0.1.74 milestone Jun 28, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built the rhel8 product both with and without the new option and I have examined that the per-rule Ansible Playbooks are and aren't there.

@jan-cerny jan-cerny merged commit 02ff410 into ComplianceAsCode:master Jun 28, 2024
91 of 93 checks passed
@Mab879 Mab879 added the Infrastructure Our content build system label Jun 28, 2024
@mildas mildas deleted the playbook_per_rule_build branch July 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants