Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatus for ubuntu2204 #12121

Closed

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jul 2, 2024

Description:

Install xsltproc for Automatus content build on Ubuntu 22.04.

Rationale:

So the tests work.
Review Hints:

  • Review the CI and ensure that "Automatus Ubuntu 22.04" passes.
  • Once approved I will remove the example commit that triggered the CI.

@Mab879 Mab879 added the Infrastructure Our content build system label Jul 2, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jul 2, 2024
@Mab879 Mab879 marked this pull request as ready for review July 2, 2024 15:43
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 2, 2024
Copy link

openshift-ci bot commented Jul 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 2, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12121
This image was built from commit: e24cadd

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12121

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12121 make deploy-local

@Mab879 Mab879 force-pushed the fix_automatus_for_ubuntu2204 branch 3 times, most recently from 967d8e5 to f2f93ba Compare July 2, 2024 18:45
@Mab879 Mab879 force-pushed the fix_automatus_for_ubuntu2204 branch 3 times, most recently from 9a747f9 to 10fa1a2 Compare July 2, 2024 19:42
@Mab879 Mab879 force-pushed the fix_automatus_for_ubuntu2204 branch from 10fa1a2 to 0ab9cc1 Compare July 2, 2024 20:16
@Mab879 Mab879 marked this pull request as draft July 2, 2024 21:43
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 2, 2024
@vojtapolasek vojtapolasek self-assigned this Jul 10, 2024
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mab879 LGTM, I encountered this issue as well and came with the same fix, so I approve.

@Mab879
Copy link
Member Author

Mab879 commented Jul 10, 2024

@Mab879 LGTM, I encountered this issue as well and came with the same fix, so I approve.

This fixes the build step but the running step is still needs some attention.

@Mab879 Mab879 force-pushed the fix_automatus_for_ubuntu2204 branch from 20e46f8 to a543a2e Compare July 10, 2024 10:36
@Mab879 Mab879 force-pushed the fix_automatus_for_ubuntu2204 branch from 5207109 to e24cadd Compare July 12, 2024 15:43
Copy link

codeclimate bot commented Jul 12, 2024

Code Climate has analyzed commit e24cadd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@vojtapolasek
Copy link
Collaborator

@ComplianceAsCode/ubuntu-maintainers any idea how to fix this please?

@dodys
Copy link
Contributor

dodys commented Jul 17, 2024 via email

@dodys
Copy link
Contributor

dodys commented Jul 22, 2024

@Mab879 did #12175 fix the issue? Should we close this one?

@Mab879
Copy link
Member Author

Mab879 commented Jul 22, 2024

That doesn't slove

@Mab879 did #12175 fix the issue? Should we close this one?

That solves one of the issues. However, the Dockerfiles/test_suite-ubt22 file still doesn't exist which is problem.

@dodys
Copy link
Contributor

dodys commented Jul 22, 2024

That doesn't slove

@Mab879 did #12175 fix the issue? Should we close this one?

That solves one of the issues. However, the Dockerfiles/test_suite-ubt22 file still doesn't exist which is problem.

@alanmcanonical could you check this second issue too?

@Mab879
Copy link
Member Author

Mab879 commented Jul 29, 2024

Closing in favor #12230

@Mab879 Mab879 closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Used by openshift-ci bot. Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants