-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default hashing algorithm settings in ANSSI profiles for RHEL #12127
Change default hashing algorithm settings in ANSSI profiles for RHEL #12127
Conversation
ANSSI allows two hashing algorithms with pam_unix.so, sha512 and yescrypt. Currently, RHEL products use sha512 by default, which is already compliant so the respective ANSSI profiles were updated to check for sha512 instead of yescrypt. This will better align to system default settings and avoid unnecessary changes. Signed-off-by: Marcus Burghardt <[email protected]>
Skipping CI for Draft Pull Request. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit 0effad1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
I am waiving the failing test, the test fails on OL7 container while changes are related to RHEL 8 and 9.
Description:
ANSSI allows two hashing algorithms with
pam_unix.so
:sha512
andyescrypt
.Currently, RHEL products use
sha512
by default, which is already compliant.Therefore, the respective ANSSI profiles were updated to check for
sha512
values instead ofyescrypt
.This will better align to system default settings and avoid unnecessary changes.
Rationale:
Review Hints:
After applying the remediation for
accounts_password_pam_unix_rounds_system_auth
rule from ANSSI profiles for RHEL, the number ofrounds
configured for pam_unix.so in/etc/pam.d/system-auth
is now appropriated tosha512
.The most relevant variable is
var_password_pam_unix_rounds
but I also updatedvar_password_hashing_algorithm
variable option to ensure/etc/login.defs
is also aligned with default settings.