Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide/anssi r45 #12129

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Guide/anssi r45 #12129

merged 3 commits into from
Jul 17, 2024

Conversation

a-skr
Copy link
Contributor

@a-skr a-skr commented Jul 4, 2024

Description:

  • Add rules for R45 in anssi guide

Rationale:

  • There was previously no rules attached to this recommendation.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 4, 2024

Hi @a-skr. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12129
This image was built from commit: edbaec1

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12129

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12129 make deploy-local

Mab879
Mab879 requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I have left some feedback to help you get the CI green.

products/debian12/profiles/anssi_bp28_enhanced.profile
- 'grub2_enable_apparmor'
- 'package_apparmor_installed'
- 'package_pam_apparmor_installed'
- '!sebool_selinuxuser_execheap'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the CI you will need to do the same to RHEL8-RHEL10 profiles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update RHEL profiles in a few days. Thank you for your review.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RHEL profiles have been updated.

@Mab879 Mab879 self-assigned this Jul 9, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jul 9, 2024
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Jul 9, 2024
@a-skr a-skr requested a review from a team as a code owner July 11, 2024 12:48
@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Jul 13, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Jul 16, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jul 16, 2024

Code Climate has analyzed commit edbaec1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Jul 16, 2024

Waving Automatus Sanity as it is not caused by this PR.

Mab879
Mab879 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879
Copy link
Member

Mab879 commented Jul 17, 2024

/packit retest-failed

@Mab879 Mab879 merged commit 6ca547b into ComplianceAsCode:master Jul 17, 2024
88 of 90 checks passed
@a-skr a-skr deleted the guide/anssi-R45 branch July 18, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
needs-ok-to-test Used by openshift-ci bot. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.74
Development

Successfully merging this pull request may close these issues.
3 participants
@a-skr @Mab879 @openshift-merge-robot