Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to show XML content with problem #12132

Conversation

marcusburghardt
Copy link
Member

@marcusburghardt marcusburghardt commented Jul 5, 2024

Description:

When working with OVAL it is not difficult spend a lot of time trying to identify a typo or an incorrect syntax. This commit include a minor update to help developers to see which content was causing an exception. This is specially helpful when multiple OVAL files are changed.

Rationale:

Make developers lives easier.

Review Hints:

Please, don't worry trying this PR right now.
I did this change when working on some more complex rules.
It happened when I tried some Jinja2 variables with OVAL objects but no longer have the information to reproduce it now.
I will come back to this PR in another opportunity to review it. For now I only documenting the change.

When working with OVAL it is not difficult spend a lot of time trying to
identify a typo or an incorrect syntax. This commit include a minor
update to help developers to see which content was causing an exception.
This is specially helpful when multiple OVAL files are changed.

Signed-off-by: Marcus Burghardt <[email protected]>
@marcusburghardt marcusburghardt added the Infrastructure Our content build system label Jul 5, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 5, 2024
Copy link

openshift-ci bot commented Jul 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

github-actions bot commented Jul 5, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 5, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12132
This image was built from commit: 1e81165

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12132

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12132 make deploy-local

Copy link

codeclimate bot commented Jul 5, 2024

Code Climate has analyzed commit 1e81165 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 40.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@marcusburghardt
Copy link
Member Author

I no longer have the files where this issue was hit and in a quick try I couldn't reproduce.
I will close it now. If I hit it again in the future I reopen the PR.

@marcusburghardt marcusburghardt deleted the debug_xml_string branch July 8, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Used by openshift-ci bot. Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant