Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that RHEL 10 has CCEs #12137

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jul 8, 2024

Description:

Add RHEL 10 to missing CCEs test.

Rationale:

Help with RHEL 10 development.

@Mab879 Mab879 added the Infrastructure Our content build system label Jul 8, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 8, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12137
This image was built from commit: 57f4551

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12137

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12137 make deploy-local

@Mab879 Mab879 requested a review from a team as a code owner July 8, 2024 16:26
Copy link

codeclimate bot commented Jul 8, 2024

Code Climate has analyzed commit 57f4551 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Jul 9, 2024
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security_patches_up_to_date is still present in anssi control file, so it would now be included in RHEL 10 ANSSI profiles. Is it the intention? I understood the intention was to not use this rule in RHEL 10 for now.

@Mab879
Copy link
Member Author

Mab879 commented Jul 12, 2024

security_patches_up_to_date is still present in anssi control file, so it would now be included in RHEL 10 ANSSI profiles. Is it the intention? I understood the intention was to not use this rule in RHEL 10 for now.

The ANSSI control file is used in other operating systems than RHEL10; so we shouldn't remove it from the ANSSI control file. I removed security_patches_up_to_date RHEL 10 by excluding in the rule in the ANSSI profiles. The controls where it was removed was the ones that are only used in RHEL 10.

@marcusburghardt
Copy link
Member

security_patches_up_to_date is still present in anssi control file, so it would now be included in RHEL 10 ANSSI profiles. Is it the intention? I understood the intention was to not use this rule in RHEL 10 for now.

The ANSSI control file is used in other operating systems than RHEL10; so we shouldn't remove it from the ANSSI control file. I removed security_patches_up_to_date RHEL 10 by excluding in the rule in the ANSSI profiles. The controls where it was removed was the ones that are only used in RHEL 10.

Nevermind. My confusion.

@marcusburghardt marcusburghardt added the RHEL10 Red Hat Enterprise Linux 10 product related. label Jul 12, 2024
@marcusburghardt marcusburghardt merged commit 56d14eb into ComplianceAsCode:master Jul 12, 2024
93 of 94 checks passed
@Mab879 Mab879 deleted the add_rhel10_to_missing_cces_test branch July 12, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system RHEL10 Red Hat Enterprise Linux 10 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants