Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package_firewalld_installed to CCN and enable CCN Advanced profile test in CI #12139

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Jul 9, 2024

Description:

During testing of CCN profile in CI, Ansible playbook fatal error got discovered caused by missing firewalld - https://artifacts.dev.testing-farm.io/580411a3-6359-4b79-aea3-917376355d7a/#artifacts-/hardening/host-os/ansible/ccn_advanced (for fatal error, see https://artifacts.dev.testing-farm.io/580411a3-6359-4b79-aea3-917376355d7a/work-ccn_advanced7b8m02tc/hardening/host-os/ansible/ccn_advanced/execute/data/guest/default-0/hardening/host-os/ansible/ccn_advanced-1/output.txt)
With package_firewalld_installed (which seems reasonable to be part of The System Has an Activated Local Firewall requirement), everything is fine.

Now, when CCN Advanced playbook passes on Centos Stream 9, it can be enabled in CI.

Rationale:

Fix for cases when firewalld is not installed by default + increase test coverage in CI.

Review Hints:

See Testing Farm results for CCN Advanced profile (the profile is RHEL9 only).

@mildas mildas marked this pull request as draft July 9, 2024 06:35
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 9, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12139
This image was built from commit: dbb2c78

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12139

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12139 make deploy-local

To enable and configure firewalld, the package containing it must be
installed.
Copy link

codeclimate bot commented Jul 9, 2024

Code Climate has analyzed commit dbb2c78 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@mildas mildas changed the title Enable CCN Advanced profile test in CI Add package_firewalld_installed to CCN and enable CCN Advanced profile test in CI Jul 9, 2024
@mildas mildas added this to the 0.1.74 milestone Jul 9, 2024
@mildas mildas marked this pull request as ready for review July 9, 2024 11:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 9, 2024
@mildas mildas added RHEL9 Red Hat Enterprise Linux 9 product related. CCN CCN Benchmark related. labels Jul 9, 2024
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcusburghardt marcusburghardt self-assigned this Jul 9, 2024
@marcusburghardt marcusburghardt merged commit a2c51f1 into ComplianceAsCode:master Jul 9, 2024
94 of 95 checks passed
@mildas mildas deleted the test_ccn_in_ci branch July 17, 2024 12:47
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCN CCN Benchmark related. RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants