Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notes and Controls for SYS.1.6.A1-A4 #12161

Merged

Conversation

sluetze
Copy link
Contributor

@sluetze sluetze commented Jul 16, 2024

Description:

This PR implements mostly notes and reuses some existing rules.

Rationale:

Customer asked for BSI Profile

Review Hints:

Currently the build is broken due to reference_type used.
We have two control files (bsi_app_4_4 and bsi_sys_1_6 ) I configured both of them with reference_type: bsi expecting the autolabeling to “merge” the different requirements from the control files to the references. But this does not seem to work as expected. during the build the build fails with ValueError: Rule accounts_no_clusterrolebindings_default_service_account contains bsi reference, but this reference type is provided by bsi_sys_1_6 controls. Please remove the reference from rule.yml. even though the mentioned rule does not include a reference and also is not referenced in bsi_sys_1_6 control file
changing the reference to another name results in unknown reference (ValueError: Unknown reference type bsi_sys)
I suspect that the referencing is done for bsi_app_4_4 control file and afterwards the pre-check of the bsi_sys_1_6 for references fails.

Copy link

openshift-ci bot commented Jul 16, 2024

Hi @sluetze. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 18, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12161
This image was built from commit: 32204e8

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12161

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12161 make deploy-local

Copy link

codeclimate bot commented Jul 18, 2024

Code Climate has analyzed commit 32204e8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added the OpenShift OpenShift product related. label Jul 19, 2024
@yuumasato yuumasato self-assigned this Aug 12, 2024
@BhargaviGudi
Copy link
Collaborator

QE: /lgtm

@yuumasato yuumasato added this to the 0.1.75 milestone Sep 3, 2024
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I have tried this PR rebased on latest master to check whether any rule reference would conflict, and everything worked.

@yuumasato yuumasato merged commit 391a81a into ComplianceAsCode:master Sep 3, 2024
89 of 90 checks passed
@yuumasato yuumasato added the BSI PRs or issues for the BSI profile. label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSI PRs or issues for the BSI profile. needs-ok-to-test Used by openshift-ci bot. OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants