Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMP-2461: Requirement 9 is not applicable #12166

Merged
merged 1 commit into from
Jul 18, 2024
Merged

CMP-2461: Requirement 9 is not applicable #12166

merged 1 commit into from
Jul 18, 2024

Conversation

yuumasato
Copy link
Member

Description:

  • Requirement 9 is not applicable for OpenShift

Rationale:

  • Managing the physical security of POI and media with cardholder data is not in scope for OpenShift.

@yuumasato
CMP-2461: Requirement 9 is not applicable
2ead421 
Managing the physical security of POI and media with cardholder data is
not in scope for OpenShift.
@yuumasato yuumasato added OpenShift OpenShift product related. pci-dss labels Jul 16, 2024
@yuumasato yuumasato requested a review from rhmdnd July 16, 2024 14:51
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12166
This image was built from commit: 2ead421

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12166

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12166 make deploy-local

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jul 16, 2024

Code Climate has analyzed commit 2ead421 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

rhmdnd
rhmdnd approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd added this to the 0.1.74 milestone Jul 16, 2024
yuumasato
yuumasato commented Jul 17, 2024
View reviewed changes
controls/pcidss_4_ocp4.yml
controls:
- id: 9.4.1
title: All media with cardholder data is physically secured.
description: |-
Media with cardholder data cannot be accessed by unauthorized personnel.
levels:
- base
status: pending
status: not applicable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering whether this requirement isn't actually manual, instead of not applicable

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see several of these controls being manual if you consider the physical perspective (e.g., you need to build fences around your cluster to meet requirement 9.2).

Marking them as manual seems to align with what RHEL did. Either way, I don't think these statuses will show up in the actual operator since they're not backed by any rules.

@xiaojiey
Copy link
Collaborator

/lgtm

1 similar comment
@Vincent056
Copy link
Contributor

/lgtm

rhmdnd
rhmdnd approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd merged commit d1c6ef3 into ComplianceAsCode:master Jul 18, 2024
94 of 95 checks passed
@yuumasato yuumasato deleted the pcidss_4_requirement_9 branch July 19, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhmdnd rhmdnd rhmdnd approved these changes

Assignees

@rhmdnd rhmdnd

Labels
OpenShift OpenShift product related. pci-dss
Projects
None yet
Milestone
0.1.74
Development

Successfully merging this pull request may close these issues.
4 participants
@yuumasato @xiaojiey @Vincent056 @rhmdnd