Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule sshd_use_approved_ciphers back to RHEL 9 data stream #12174

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

jan-cerny
Copy link
Collaborator

In #12150 we removed sshd_use_approved_ciphers from RHEL 9 profiles.

This caused that the rule disappeared from the built data stream. That can break people tailorings. Also, it breaks the CI test /static-checks/removed-rules. For example:
https://artifacts.dev.testing-farm.io/a38de8f4-1581-4bff-b690-c3d6f854d047/

We need to add the rule back. The rule is added to the hidden default profile, which causes that the rule is present in built data stream, but isn't present in any profile.

In ComplianceAsCode#12150
we removed sshd_use_approved_ciphers from RHEL 9 profiles.

This caused that the rule disappeared from the built data stream.
That can break people tailorings. Also, it breaks the CI
test /static-checks/removed-rules. For example:
https://artifacts.dev.testing-farm.io/a38de8f4-1581-4bff-b690-c3d6f854d047/

We need to add the rule back. The rule is added to the hidden default
profile, which causes that the rule is present in built data stream, but
isn't present in any profile.
@jan-cerny jan-cerny requested a review from a team as a code owner July 17, 2024 07:25
@jan-cerny jan-cerny added this to the 0.1.74 milestone Jul 17, 2024
@jan-cerny jan-cerny added BLOCKER Impediments to release, like failure to build content, or content built is out of standard's syntax and removed BLOCKER Impediments to release, like failure to build content, or content built is out of standard's syntax labels Jul 17, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12174
This image was built from commit: a6f3398

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12174

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12174 make deploy-local

@marcusburghardt marcusburghardt added the RHEL9 Red Hat Enterprise Linux 9 product related. label Jul 17, 2024
Copy link

codeclimate bot commented Jul 17, 2024

Code Climate has analyzed commit a6f3398 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Jul 17, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879 Mab879 merged commit 10f3b94 into ComplianceAsCode:master Jul 17, 2024
93 of 95 checks passed
@Mab879 Mab879 added the bugfix Fixes to reported bugs. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. RHEL9 Red Hat Enterprise Linux 9 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants