Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rules from the net-snmp component #12391

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Sep 17, 2024

Description:

Various improvements for rules in the net-snmp component.

Relational:

Update based on maintainer feedback.

@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Sep 17, 2024
@Mab879 Mab879 added this to the 0.1.75 milestone Sep 17, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_snmpd_no_rwusers'.
--- xccdf_org.ssgproject.content_rule_snmpd_no_rwusers
+++ xccdf_org.ssgproject.content_rule_snmpd_no_rwusers
@@ -5,7 +5,7 @@
 [description]:
 Edit /etc/snmp/snmpd.conf, remove any rwuser entries.
 Once the read write users have been removed, restart the SNMP service:
-$ sudo service snmpd restart
+$ sudo systemctl restart snmpd
 
 [rationale]:
 Certain SNMP settings can permit users to execute system behaviors from user

New content has different text for rule 'xccdf_org.ssgproject.content_rule_snmpd_not_default_password'.
--- xccdf_org.ssgproject.content_rule_snmpd_not_default_password
+++ xccdf_org.ssgproject.content_rule_snmpd_not_default_password
@@ -7,7 +7,7 @@
 public and private.
 This profile configures new read-only community string to 'xccdf_org.ssgproject.content_value_var_snmpd_ro_string' and read-write community string to 'xccdf_org.ssgproject.content_value_var_snmpd_rw_string'.
 Once the default community strings have been changed, restart the SNMP service:
-$ sudo service snmpd restart
+$ sudo systemctl restart snmpd
 
 [reference]:
 1

New content has different text for rule 'xccdf_org.ssgproject.content_rule_snmpd_use_newer_protocol'.
--- xccdf_org.ssgproject.content_rule_snmpd_use_newer_protocol
+++ xccdf_org.ssgproject.content_rule_snmpd_use_newer_protocol
@@ -5,7 +5,7 @@
 [description]:
 Edit /etc/snmp/snmpd.conf, removing any references to rocommunity, rwcommunity, or com2sec.
 Upon doing that, restart the SNMP service:
-$ sudo service snmpd restart
+$ sudo systemctl restart snmpd
 
 [reference]:
 1311

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12391
This image was built from commit: cbfde5b

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12391

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12391 make deploy-local

Copy link

codeclimate bot commented Sep 17, 2024

Code Climate has analyzed commit cbfde5b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@marcusburghardt marcusburghardt self-assigned this Sep 18, 2024
@marcusburghardt
Copy link
Member

Failure with xwindows_remove_packages is not related to this PR.
Reported issue #12394

@marcusburghardt marcusburghardt merged commit a15b5b0 into ComplianceAsCode:master Sep 18, 2024
97 of 100 checks passed
@Mab879 Mab879 deleted the ffix_net-snmp branch September 18, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants