Fix incorrect file mode

[alanmcanonical]

Description:

• Fix incorrect file mode for dir_permissions_library_dirs and file_permissions_library_dirs

Rationale:

• The 7 as special mode is incorrect for those file and path

[openshift-ci]

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_dir_permissions_library_dirs' differs.
--- xccdf_org.ssgproject.content_rule_dir_permissions_library_dirs
+++ xccdf_org.ssgproject.content_rule_dir_permissions_library_dirs
@@ -3,10 +3,10 @@
 
 
 
-find -H /lib/  -perm /g+w,o+w -type d -exec chmod g-w,o-w {} \;
+find -H /lib/  -perm /u+s,g+ws,o+wt -type d -exec chmod u-s,g-ws,o-wt {} \;
 
-find -H /lib64/  -perm /g+w,o+w -type d -exec chmod g-w,o-w {} \;
+find -H /lib64/  -perm /u+s,g+ws,o+wt -type d -exec chmod u-s,g-ws,o-wt {} \;
 
-find -H /usr/lib/  -perm /g+w,o+w -type d -exec chmod g-w,o-w {} \;
+find -H /usr/lib/  -perm /u+s,g+ws,o+wt -type d -exec chmod u-s,g-ws,o-wt {} \;
 
-find -H /usr/lib64/  -perm /g+w,o+w -type d -exec chmod g-w,o-w {} \;
+find -H /usr/lib64/  -perm /u+s,g+ws,o+wt -type d -exec chmod u-s,g-ws,o-wt {} \;

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_dir_permissions_library_dirs' differs.
--- xccdf_org.ssgproject.content_rule_dir_permissions_library_dirs
+++ xccdf_org.ssgproject.content_rule_dir_permissions_library_dirs
@@ -1,5 +1,5 @@
 - name: Find /lib/ file(s) recursively
-  command: 'find -H /lib/  -perm /g+w,o+w  -type d '
+  command: 'find -H /lib/  -perm /u+s,g+ws,o+wt  -type d '
   register: files_found
   changed_when: false
   failed_when: false
@@ -20,7 +20,7 @@
 - name: Set permissions for /lib/ file(s)
   file:
     path: '{{ item }}'
-    mode: g-w,o-w
+    mode: u-s,g-ws,o-wt
     state: directory
   with_items:
   - '{{ files_found.stdout_lines }}'
@@ -38,7 +38,7 @@
   - no_reboot_needed
 
 - name: Find /lib64/ file(s) recursively
-  command: 'find -H /lib64/  -perm /g+w,o+w  -type d '
+  command: 'find -H /lib64/  -perm /u+s,g+ws,o+wt  -type d '
   register: files_found
   changed_when: false
   failed_when: false
@@ -59,7 +59,7 @@
 - name: Set permissions for /lib64/ file(s)
   file:
     path: '{{ item }}'
-    mode: g-w,o-w
+    mode: u-s,g-ws,o-wt
     state: directory
   with_items:
   - '{{ files_found.stdout_lines }}'
@@ -77,7 +77,7 @@
   - no_reboot_needed
 
 - name: Find /usr/lib/ file(s) recursively
-  command: 'find -H /usr/lib/  -perm /g+w,o+w  -type d '
+  command: 'find -H /usr/lib/  -perm /u+s,g+ws,o+wt  -type d '
   register: files_found
   changed_when: false
   failed_when: false
@@ -98,7 +98,7 @@
 - name: Set permissions for /usr/lib/ file(s)
   file:
     path: '{{ item }}'
-    mode: g-w,o-w
+    mode: u-s,g-ws,o-wt
     state: directory
   with_items:
   - '{{ files_found.stdout_lines }}'
@@ -116,7 +116,7 @@
   - no_reboot_needed
 
 - name: Find /usr/lib64/ file(s) recursively
-  command: 'find -H /usr/lib64/  -perm /g+w,o+w  -type d '
+  command: 'find -H /usr/lib64/  -perm /u+s,g+ws,o+wt  -type d '
   register: files_found
   changed_when: false
   failed_when: false
@@ -137,7 +137,7 @@
 - name: Set permissions for /usr/lib64/ file(s)
   file:
     path: '{{ item }}'
-    mode: g-w,o-w
+    mode: u-s,g-ws,o-wt
     state: directory
   with_items:
   - '{{ files_found.stdout_lines }}'

bash remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_library_dirs' differs.
--- xccdf_org.ssgproject.content_rule_file_permissions_library_dirs
+++ xccdf_org.ssgproject.content_rule_file_permissions_library_dirs
@@ -3,10 +3,10 @@
 
 
 
-find -H /lib/  -perm /g+w,o+w  -type f -regextype posix-extended -regex '^.*$' -exec chmod g-w,o-w {} \;
+find -H /lib/  -perm /u+s,g+ws,o+wt  -type f -regextype posix-extended -regex '^.*$' -exec chmod u-s,g-ws,o-wt {} \;
 
-find -H /lib64/  -perm /g+w,o+w  -type f -regextype posix-extended -regex '^.*$' -exec chmod g-w,o-w {} \;
+find -H /lib64/  -perm /u+s,g+ws,o+wt  -type f -regextype posix-extended -regex '^.*$' -exec chmod u-s,g-ws,o-wt {} \;
 
-find -H /usr/lib/  -perm /g+w,o+w  -type f -regextype posix-extended -regex '^.*$' -exec chmod g-w,o-w {} \;
+find -H /usr/lib/  -perm /u+s,g+ws,o+wt  -type f -regextype posix-extended -regex '^.*$' -exec chmod u-s,g-ws,o-wt {} \;
 
-find -H /usr/lib64/  -perm /g+w,o+w  -type f -regextype posix-extended -regex '^.*$' -exec chmod g-w,o-w {} \;
+find -H /usr/lib64/  -perm /u+s,g+ws,o+wt  -type f -regextype posix-extended -regex '^.*$' -exec chmod u-s,g-ws,o-wt {} \;

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_library_dirs' differs.
--- xccdf_org.ssgproject.content_rule_file_permissions_library_dirs
+++ xccdf_org.ssgproject.content_rule_file_permissions_library_dirs
@@ -1,6 +1,6 @@
 - name: Find /lib/ file(s) recursively
-  command: find -H /lib/  -perm /g+w,o+w  -type f -regextype posix-extended -regex
-    "^.*$"
+  command: find -H /lib/  -perm /u+s,g+ws,o+wt  -type f -regextype posix-extended
+    -regex "^.*$"
   register: files_found
   changed_when: false
   failed_when: false
@@ -22,7 +22,7 @@
 - name: Set permissions for /lib/ file(s)
   file:
     path: '{{ item }}'
-    mode: g-w,o-w
+    mode: u-s,g-ws,o-wt
     state: file
   with_items:
   - '{{ files_found.stdout_lines }}'
@@ -41,8 +41,8 @@
   - no_reboot_needed
 
 - name: Find /lib64/ file(s) recursively
-  command: find -H /lib64/  -perm /g+w,o+w  -type f -regextype posix-extended -regex
-    "^.*$"
+  command: find -H /lib64/  -perm /u+s,g+ws,o+wt  -type f -regextype posix-extended
+    -regex "^.*$"
   register: files_found
   changed_when: false
   failed_when: false
@@ -64,7 +64,7 @@
 - name: Set permissions for /lib64/ file(s)
   file:
     path: '{{ item }}'
-    mode: g-w,o-w
+    mode: u-s,g-ws,o-wt
     state: file
   with_items:
   - '{{ files_found.stdout_lines }}'
@@ -83,8 +83,8 @@
   - no_reboot_needed
 
 - name: Find /usr/lib/ file(s) recursively
-  command: find -H /usr/lib/  -perm /g+w,o+w  -type f -regextype posix-extended -regex
-    "^.*$"
+  command: find -H /usr/lib/  -perm /u+s,g+ws,o+wt  -type f -regextype posix-extended
+    -regex "^.*$"
   register: files_found
   changed_when: false
   failed_when: false
@@ -106,7 +106,7 @@
 - name: Set permissions for /usr/lib/ file(s)
   file:
     path: '{{ item }}'
-    mode: g-w,o-w
+    mode: u-s,g-ws,o-wt
     state: file
   with_items:
   - '{{ files_found.stdout_lines }}'
@@ -125,7 +125,7 @@
   - no_reboot_needed
 
 - name: Find /usr/lib64/ file(s) recursively
-  command: find -H /usr/lib64/  -perm /g+w,o+w  -type f -regextype posix-extended
+  command: find -H /usr/lib64/  -perm /u+s,g+ws,o+wt  -type f -regextype posix-extended
     -regex "^.*$"
   register: files_found
   changed_when: false
@@ -148,7 +148,7 @@
 - name: Set permissions for /usr/lib64/ file(s)
   file:
     path: '{{ item }}'
-    mode: g-w,o-w
+    mode: u-s,g-ws,o-wt
     state: file
   with_items:
   - '{{ files_found.stdout_lines }}'

[github-actions]

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

[codeclimate]

Code Climate has analyzed commit 85fe24e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.