SLE15 related fixes in ntp and aide rules

[teacup-on-rockingchair]

Description:

• Some bug fixes for SLE platform in remediations for ntp and aide rules

Rationale:

• Fix maxpoll remediatian also for cases when maxpoll is negative
• Fix bug with register ansible variable in permissions_local_var_log_audit rule, causing exception
• Remediate AIDE periodic cron check in SLE via settings in crontab file

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_chronyd_or_ntpd_set_maxpoll' differs.
--- xccdf_org.ssgproject.content_rule_chronyd_or_ntpd_set_maxpoll
+++ xccdf_org.ssgproject.content_rule_chronyd_or_ntpd_set_maxpoll
@@ -20,7 +20,7 @@
 
 for config_file in "${CONFIG_FILES[@]}" ; do
     # Set maxpoll values to var_time_service_set_maxpoll
-    sed -i "s/^\(\(server\|pool\|peer\).*maxpoll\) [0-9][0-9]*\(.*\)$/\1 $var_time_service_set_maxpoll \3/" "$config_file"
+    sed -i "s/^\(\(server\|pool\|peer\).*maxpoll\) [0-9,-][0-9]*\(.*\)$/\1 $var_time_service_set_maxpoll \3/" "$config_file"
 done
 
 for config_file in "${CONFIG_FILES[@]}" ; do

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_chronyd_or_ntpd_set_maxpoll' differs.
--- xccdf_org.ssgproject.content_rule_chronyd_or_ntpd_set_maxpoll
+++ xccdf_org.ssgproject.content_rule_chronyd_or_ntpd_set_maxpoll
@@ -172,7 +172,7 @@
 - name: Configure Time Service Maxpoll Interval - Update the maxpoll Values in /etc/chrony.d/
   ansible.builtin.replace:
     path: '{{ item.path }}'
-    regexp: ^((?:server|pool|peer).*maxpoll)[ ]+[0-9]+(.*)$
+    regexp: ^((?:server|pool|peer).*maxpoll)[ ]+[0-9,-]+(.*)$
     replace: \1 {{ var_time_service_set_maxpoll }}\2
   loop: '{{ chrony_d_conf_files.files }}'
   when:

[codeclimate]

Code Climate has analyzed commit ea19d37 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

[jan-cerny]

I have run test scenarios on a RHEL 9 VM abckend and they passed.