Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: trying to fix Automatus sanity check #12553

Conversation

vojtapolasek
Copy link
Collaborator

Automatus sanity check is sometimes failing. The reason is that the rule file_owner_etc_issue_net is being scanned and it fails.
The fail might be legitimate, but the peculiar thing is that when testing locally on Fedora, the rule does not get picked by the last test run.
The particular test run tests the template feature of Automatus and it uses slice 1 of 15 for file_owner template.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_accounts_user_interactive_home_directory_defined' differs.
--- xccdf_org.ssgproject.content_rule_accounts_user_interactive_home_directory_defined
+++ xccdf_org.ssgproject.content_rule_accounts_user_interactive_home_directory_defined
@@ -33,7 +33,7 @@
   loop: '{{ local_users }}'
   when:
   - item.value[2]|int >= 1000
-  - item.value[2]|int != 65534
+  - item.value[2]|int != 65535
   - not item.value[4] | regex_search('^\/\w*\/\w{1,}')
   tags:
   - CCE-84036-3

Copy link

codeclimate bot commented Oct 30, 2024

Code Climate has analyzed commit fae4baa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek marked this pull request as draft October 30, 2024 15:34
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant