Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Benchmark detection in Automatus #12554

Merged
merged 1 commit into from
Nov 4, 2024

Commits on Oct 30, 2024

  1. Improve Benchmark detection in Automatus

    The SCE checks are inserted to SCAP source data stream in a form of
    `extended-component` element, each SCE check as a separate
    `extended-component` element. We shouldn't treat these extended
    component as XCCDF Benchmarks. Instead, when resolving a component
    reference we should check if the reference really points to an XCCDF
    Benchmark.
    
    This fix will remove these annoying messages from automatus output:
    
    ```
    INFO - The data stream contains 132 Benchmarks
    INFO - 0 - scap_org.open-scap_cref_ssg-rhel9-xccdf.xml
    INFO - 1 - scap_org.open-scap_cref_rhel9-checks-sce-timer_dnf-automatic_enabled.sh
    INFO - 2 - scap_org.open-scap_cref_rhel9-checks-sce-service_debug-shell_disabled.sh
    INFO - 3 - scap_org.open-scap_cref_rhel9-checks-sce-service_pcscd_enabled.sh
    ...
    ```
    jan-cerny committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    fce616a View commit details
    Browse the repository at this point in the history