Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pallet-cosmwasm: remove unnecessary as uXX casts on literals #3822

Closed
wants to merge 1 commit into from
Closed

pallet-cosmwasm: remove unnecessary as uXX casts on literals #3822

wants to merge 1 commit into from

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Jul 21, 2023 •
edited
Loading

In most cases Rust can figure out the type of an integer literal so an explicit as uXX cast is not necessary. In a couple of places where the type is needed to disambiguate types, using typed integer literal is more concise.

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • I have linked Zenhub/Github or any other reference item if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • I waited and did best effort for pr-workflow-check / draft-release-check to finish with success(green check mark) with my changes
  • I have added at least one reviewer in reviewers list
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production

@mina86
pallet-cosmwasm: remove unnecessary as uXX casts on literals
15fa4fa 
In most cases Rust can figure out the type of an integer literal so an
explicit `as uXX` cast is not necessary.  In a couple of places where
the type is needed to disambiguate types, using typed integer literal
is more concise.
@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 21 9d 9h 34m 54
RustNinja 15 4h 57m 0
blasrodri 7 23h 36m 3
kkast 6 2d 5h 55m 4
0xBrainjar2 4 4h 10m 2
mina86 3 2d 20h 36m 25
vmarkushin 1 12d 19h 41m 3
josietyleung 1 1d 20h 28m 3

@mina86 mina86 added Bridging Team Issues for Bridging Team Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform and removed Bridging Team Issues for Bridging Team labels Jul 21, 2023
@mina86 mina86 enabled auto-merge July 21, 2023 19:48
@dzmitry-lahoda
Copy link
Contributor

that is generated i guess. on regeneration it will be again here.

@mina86
Copy link
Contributor Author

mina86 commented Jul 21, 2023

D’oh, you’re right. I somehow missed the giant message at the top.

@mina86 mina86 closed this Jul 21, 2023
auto-merge was automatically disabled July 21, 2023 20:01

Pull request was closed

@mina86 mina86 deleted the mpn/a branch July 21, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzmitry-lahoda dzmitry-lahoda Awaiting requested review from dzmitry-lahoda

Assignees
No one assigned
Labels
Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mina86 @dzmitry-lahoda