solana-ibc: use solana height and timestamp for cf-guest host metadata #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs to be conditional. If we’re running on Solana we have chain account and we use time from there. But if witness account is enabled, we don’t have chain account and then we read data directly from blockchain. This also made me realise that in my WIP commit adding witness to solana-ibc it should also remove the chain account since that won’t be used on Rollup. |
mina86
reviewed
Sep 7, 2024
| let timestamp_sec = clock.unix_timestamp as u64; | ||
|
|
||
| let timestamp = | ||
| ibc::Timestamp::from_nanoseconds(timestamp_sec * 10u64.pow(9)) |
There was a problem hiding this comment.
Suggested change
| ibc::Timestamp::from_nanoseconds(timestamp_sec * 10u64.pow(9)) | |
| ibc::Timestamp::from_nanoseconds(timestamp_sec * 10u64.ipow(9)) |
There was a problem hiding this comment.
we would need num dependency if we wanna use ipow right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the cf-guest light client would exist on rollup, the host metadata is the solana slot and the timestamp instead of those fetched from the guest chain since the rollup wouldnt have it.
But if the connection is established to another svm where the guest chain is used, then the above should be reverted.