fix: connected account bugfix

[shreysingla11]

Earlier the toolset picked the first connected account. Now, it picks the latest connected account

---

Important

Fixes logic in get_connection method to select the latest connected account by creation date.

• Bug Fix:
  • Corrects logic in get_connection method of Entity class in __init__.py to select the latest connected account by creation date.
  • Changes comparison operator from > to < to ensure the latest account is selected.

^{This description was created by for d1bacc6. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
composio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 25, 2025 1:04pm

[entelligence-ai-pr-reviews]

The logic for finding the latest account is incorrect - using < will return the oldest account instead of newest. Should use > to get most recent creation_date.

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	creation_date = datetime.fromisoformat(
	connected_account.createdAt.replace("Z", "+00:00")
	)
	if latest_account is None or creation_date > latest_creation_date:
	if latest_account is None or creation_date < latest_creation_date:
	creation_date = datetime.fromisoformat(
	connected_account.createdAt.replace("Z", "+00:00")
	)
	if latest_account is None or creation_date > latest_creation_date:

[shreysingla11]

The variable names latest_account and latest_creation_date are misleading since we're actually tracking the earliest account. Consider renaming these to earliest_account and earliest_creation_date to better reflect their purpose.

[shreysingla11]

Consider adding a clarifying comment above this line to explain the logic:

# Find the earliest connected account based on creation date

This will help future developers understand the intention of this comparison.

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to d1bacc6 in 1 minute and 18 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. python/composio/client/__init__.py:345

• Draft comment:
  The operator is reversed. Using '<' selects the oldest account rather than the latest. For the latest account, use '>' instead.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_Ve2ZXpphvvQHmkpb

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

The condition is reversed. Using '<' here will select the oldest account, not the latest. For the intended behavior, it should be 'creation_date > latest_creation_date'.

Suggested change

	if latest_account is None or creation_date < latest_creation_date:
	if latest_account is None or creation_date > latest_creation_date:

[shreysingla11]

Code Review Summary

Changes Overview

• Fixed a critical logic error in account selection by changing > to < to correctly identify the earliest connected account
• The fix is minimal and focused, affecting only one line of code

Code Quality Assessment

• ✅ Bug fix is correct and properly addresses the issue
• 🔍 Variable naming could be improved for better clarity
• 📝 Additional documentation would be helpful
• 🏗️ Code structure and error handling remain solid

Recommendations

1. Consider renaming variables to better reflect their purpose:
   • latest_account → earliest_account
   • latest_creation_date → earliest_creation_date
2. Add clarifying comments to explain the account selection logic
3. Consider adding unit tests to verify this specific behavior

Overall, this is a valid bug fix that improves the reliability of account selection. The changes are safe to merge with the suggested improvements being optional enhancements for future consideration.