Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NVML Checks: stderr Writing #18

Merged
merged 1 commit into from
Nov 2, 2018
Merged

NVML Checks: stderr Writing #18

merged 1 commit into from
Nov 2, 2018

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Nov 2, 2018 •
edited
Loading

Do not write randomly to the error channel even if errors are catched.

Fix memtest noise reported in #16 (comment)

@ax3l ax3l added the warning label Nov 2, 2018
@ax3l ax3l requested a review from berceanu November 2, 2018 13:09
@ax3l ax3l mentioned this pull request Nov 2, 2018
Open
@ax3l ax3l force-pushed the fix-stderrWriting branch 2 times, most recently from 16cb75c to 8349e8e Compare November 2, 2018 13:23
@ax3l
NVML Checks: stderr Writing
87caf31 
Do not write randomly to stderr even if errors are catched.
berceanu
berceanu approved these changes Nov 2, 2018
View reviewed changes
Copy link

@berceanu berceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this and it works fine on my GTX 950M, solving #16.

@ax3l ax3l merged commit 6d505ea into dev Nov 2, 2018
@ax3l ax3l mentioned this pull request Nov 5, 2018
Merged
@PrometheusPi PrometheusPi deleted the fix-stderrWriting branch November 5, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berceanu berceanu berceanu approved these changes

Assignees
No one assigned
Labels
warning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @berceanu