-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add picmi_schema #5232
base: dev
Are you sure you want to change the base?
Add picmi_schema #5232
Conversation
Does PICMI somehow use this schema or is this an independent file. |
this schema in principle should check if the input file created based on the PICMI standard follows its role, eg units are correct. |
But how is the PICMI file checked against the schema, I do not see an integration into the PICMI python code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general remarks:
- the name of this schema is misleading since this schema has nothing to do with PICMI,
rather it describes the structure of the PyPIConGPU json description of an picongpu setup assumed by the meta data exporter, therefore it belongs to the meta data exporter and should use it's own project name to avoid confusion with the PyPIConGPU schemas.
- this schema is mostly a repeat of the PyPIConGPU schemas, which already specify the structure of the PyPIConGPU json description.
- this schema has nothing to do with PIConGPU and belongs to the meta data exporter project, since it describes assumptions/requirements of the meta data exporter not PIConGPU, PyPIConGPU or the PIConGPU PICMI implementation.
Add picmi_schema for picmi input files.