Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added steps to send and receive a payload in getting started #34

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MadelineMurray
Copy link
Contributor

Added steps to send and receive a payload in getting started

@MadelineMurray MadelineMurray self-assigned this Nov 18, 2020
@Krish1979
Copy link
Contributor

Krish1979 commented Nov 18, 2020

Quorum talks to Tessera via IPC, so I wouldn't change ipc connection on Q2T server to http port

@NicolasMassart NicolasMassart added the documentation Improvements or additions to documentation label Nov 18, 2020
@NicolasMassart NicolasMassart marked this pull request as draft November 18, 2020 12:17
@NicolasMassart
Copy link
Member

/receive method will be changed from GET to POST soon in Tessera. Is this PR able to wait for the change? I made it a draft for now until we decide.

@MadelineMurray
Copy link
Contributor Author

MadelineMurray commented Nov 18, 2020

Quorum talks to Tessera via IPC, so I wouldn't change ipc connection on Q2T server to http port

@Krish1979 - will do. Is there a specific reason for supporting http on the Q2T server if it's not used? Would adding a note indicating that http is being used only for learning/education purposes and IPC is needed when you're using Tessera with Quorum address this?

@Krish1979
Copy link
Contributor

Q2T connection is http over IPC and not over web port as default but we could include support over http port as well. Also to keep it generic we will be connecting Besu to Tesser over Q2T server on a http port. I would wait till we add Besu <-> Tessera operability and then update the document to reflect all the updates.

Copy link
Member

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and approved.
Just fix the spacing indicated on the comment.

}
```

Where `SGVsbG8sIFdvcmxkIQ==` is `Hello, World!` in Base64.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Where `SGVsbG8sIFdvcmxkIQ==` is `Hello, World!` in Base64.
Where `SGVsbG8sIFdvcmxkIQ==` is `Hello, World!` in Base64.

Should be part of the result tab, so need to add spaces to increment it.

=== "Result"

```bash
{"key": "5jZPbwuxncr7qrL9esCTnz3PByLlD50kdZy5JkW/JMKcFeTl7I3NeLIsje4C410EYb93HabhddoAVGpwgYF1LQ=="}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain what this key is? Public, private? What care do we have to take with this?

@NicolasMassart NicolasMassart marked this pull request as ready for review February 9, 2021 13:11
@NicolasMassart NicolasMassart marked this pull request as draft March 28, 2022 14:47
@NicolasMassart
Copy link
Member

Converted this PR to draft as it probably requires work to be up to date since Nov 2020...

@NicolasMassart NicolasMassart self-requested a review March 28, 2022 14:48
@rolandtyler rolandtyler removed the documentation Improvements or additions to documentation label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants