Merge branch 'master' into perf/DoublePairingCheck

Consensys · Sep 3, 2024 · 55685c2 · 55685c2
2 parents 0a49d97 + 1f7f38f
commit 55685c2
Show file tree

Hide file tree

Showing 137 changed files with 1,833 additions and 677 deletions.
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -9,9 +9,9 @@ jobs:
       with:
         fetch-depth: 0
     - name: install Go
-      uses: actions/setup-go@v4
+      uses: actions/setup-go@v5
       with:
-        go-version: 1.21.x
+        go-version: 1.23.x
 
     - name: install deps
       run: go install golang.org/x/tools/cmd/goimports@latest && go install github.com/klauspost/asmfmt/cmd/asmfmt@latest
@@ -30,14 +30,13 @@ jobs:
         find . -type f -name '*.go' -exec sed -i 's/Code generated by .* DO NOT EDIT/FOO/g' {} \;
       # on macos: find . -type f -name '*.go' -exec sed -i '' -E 's/Code generated by .* DO NOT EDIT/FOO/g' {} \;
     - name: golangci-lint
-      uses: golangci/golangci-lint-action@v3
+      uses: golangci/golangci-lint-action@v6
       with:
-          version: v1.54
+          version: v1.60
           args: -v --timeout=5m
-          skip-pkg-cache: true
 
   test:
-    runs-on: ubuntu-22.04-16core
+    runs-on: ubuntu-latest-128
     permissions: 
       pull-requests: write
     outputs:
@@ -46,15 +45,15 @@ jobs:
     - name: checkout code
       uses: actions/checkout@v4
     - name: install Go
-      uses: actions/setup-go@v4
+      uses: actions/setup-go@v5
       with:
-        go-version: 1.21.x
+        go-version: 1.23.x
 
     - name: install deps
       run: |
         go install golang.org/x/tools/cmd/goimports@latest && go install github.com/klauspost/asmfmt/cmd/asmfmt@latest
-        go install github.com/consensys/gnark-solidity-checker@latest
-        go install github.com/ethereum/go-ethereum/cmd/abigen@v1.12.0
+        go install github.com/consensys/gnark-solidity-checker@v0.1.0
+        go install github.com/ethereum/go-ethereum/cmd/abigen@v1.14.8
         sudo add-apt-repository ppa:ethereum/ethereum
         sudo apt-get update
         sudo apt-get install solc
@@ -98,7 +97,7 @@ jobs:
     steps:
       - name: Notify slack -- workflow failed
         id: slack
-        uses: slackapi/slack-github-action@v1.24.0
+        uses: slackapi/slack-github-action@v1.26.0
         with:
           payload: |
             {
@@ -123,7 +122,7 @@ jobs:
     steps:
       - name: Notify slack -- workflow succeeded
         id: slack
-        uses: slackapi/slack-github-action@v1.24.0
+        uses: slackapi/slack-github-action@v1.26.0
         with:
           payload: |
             {

diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
@@ -12,9 +12,9 @@ jobs:
       with:
         fetch-depth: 0
     - name: install Go
-      uses: actions/setup-go@v4
+      uses: actions/setup-go@v5
       with:
-        go-version: 1.21.x
+        go-version: 1.23.x
 
     - name: install deps
       run: go install golang.org/x/tools/cmd/goimports@latest && go install github.com/klauspost/asmfmt/cmd/asmfmt@latest
@@ -33,35 +33,34 @@ jobs:
         find . -type f -name '*.go' -exec sed -i 's/Code generated by .* DO NOT EDIT/FOO/g' {} \;
       # on macos: find . -type f -name '*.go' -exec sed -i '' -E 's/Code generated by .* DO NOT EDIT/FOO/g' {} \;
     - name: golangci-lint
-      uses: golangci/golangci-lint-action@v3
+      uses: golangci/golangci-lint-action@v6
       with:
-          version: v1.54
+          version: v1.60
           args: -v --timeout=5m
-          skip-pkg-cache: true
 
   test:
     strategy:
       matrix:
-        go-version: [1.21.x]
-        os: [ubuntu-22.04-16core, windows-latest, macos-latest]
+        go-version: [1.23.x]
+        os: [ubuntu-latest-128, windows-latest, macos-latest]
     runs-on: ${{ matrix.os }}
     needs:
       - staticcheck
     steps:
     - name: checkout code
       uses: actions/checkout@v4
     - name: install Go
-      uses: actions/setup-go@v4
+      uses: actions/setup-go@v5
       with:
         go-version: ${{ matrix.go-version }}
     - name: install deps
       run: |
         go install golang.org/x/tools/cmd/goimports@latest && go install github.com/klauspost/asmfmt/cmd/asmfmt@latest
-        go install github.com/ethereum/go-ethereum/cmd/abigen@v1.12.0
+        go install github.com/ethereum/go-ethereum/cmd/abigen@v1.14.8
     - name: install solc deps
       if: startsWith(matrix.os, 'ubuntu') == true
       run: |
-        go install github.com/consensys/gnark-solidity-checker@latest
+        go install github.com/consensys/gnark-solidity-checker@v0.1.0
         sudo add-apt-repository ppa:ethereum/ethereum
         sudo apt-get update
         sudo apt-get install solc
@@ -93,7 +92,7 @@ jobs:
     steps:
       - name: Notify slack -- workflow failed
         id: slack
-        uses: slackapi/slack-github-action@v1.24.0
+        uses: slackapi/slack-github-action@v1.26.0
         with:
           payload: |
             {
@@ -118,7 +117,7 @@ jobs:
     steps:
       - name: Notify slack -- workflow succeeded
         id: slack
-        uses: slackapi/slack-github-action@v1.24.0
+        uses: slackapi/slack-github-action@v1.26.0
         with:
           payload: |
             {

diff --git a/.golangci.yml b/.golangci.yml
@@ -7,6 +7,11 @@ linters:
     - gosimple
     - govet
     - ineffassign
-
+    - misspell
+
+linters-settings:
+  gosec:
+    excludes:
+      - G115 # Conversions from int -> uint etc.
 run:
   issues-exit-code: 1
diff --git a/backend/groth16/bls12-377/marshal_test.go b/backend/groth16/bls12-377/marshal_test.go
diff --git a/backend/groth16/bls12-377/prove.go b/backend/groth16/bls12-377/prove.go
diff --git a/backend/groth16/bls12-377/setup.go b/backend/groth16/bls12-377/setup.go
diff --git a/backend/groth16/bls12-377/verify.go b/backend/groth16/bls12-377/verify.go
diff --git a/backend/groth16/bls12-381/marshal_test.go b/backend/groth16/bls12-381/marshal_test.go
diff --git a/backend/groth16/bls12-381/prove.go b/backend/groth16/bls12-381/prove.go
diff --git a/backend/groth16/bls12-381/setup.go b/backend/groth16/bls12-381/setup.go
diff --git a/backend/groth16/bls12-381/verify.go b/backend/groth16/bls12-381/verify.go
diff --git a/backend/groth16/bls24-315/marshal_test.go b/backend/groth16/bls24-315/marshal_test.go
diff --git a/backend/groth16/bls24-315/prove.go b/backend/groth16/bls24-315/prove.go
diff --git a/backend/groth16/bls24-315/setup.go b/backend/groth16/bls24-315/setup.go
diff --git a/backend/groth16/bls24-315/verify.go b/backend/groth16/bls24-315/verify.go
diff --git a/backend/groth16/bls24-317/marshal_test.go b/backend/groth16/bls24-317/marshal_test.go
diff --git a/backend/groth16/bls24-317/prove.go b/backend/groth16/bls24-317/prove.go
diff --git a/backend/groth16/bls24-317/setup.go b/backend/groth16/bls24-317/setup.go