Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: up gnark-crypto #1274

Merged
merged 1 commit into from
Sep 10, 2024
Merged

chore: up gnark-crypto #1274

merged 1 commit into from
Sep 10, 2024

Conversation

yelhousni
Copy link
Contributor

Description

update gnark-crypto to latest which removes support of BLS12-378 and BW6-756 curves

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

wrapped_hash_test.go in std/recursion passes.

How has this been benchmarked?

N/A

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni requested review from ivokub and gbotrel and removed request for ivokub September 10, 2024 13:26
@yelhousni yelhousni added bug Something isn't working cleanup labels Sep 10, 2024
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gbotrel gbotrel merged commit e8cb61d into master Sep 10, 2024
6 checks passed
@gbotrel gbotrel deleted the chore/up-gnark-crypto branch September 10, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants