Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace stats gob format with csv for easier diffs #1276

Merged
merged 4 commits into from
Sep 13, 2024
Merged

feat: replace stats gob format with csv for easier diffs #1276

merged 4 commits into from
Sep 13, 2024

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Sep 13, 2024

Description

Stores snippets stats in CSV format to get readable diffs in CI / tests.

@gbotrel gbotrel requested a review from ivokub September 13, 2024 15:16
ivokub
ivokub approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nice to have comment, but I think lets leave it as is.

internal/stats/stats.go Show resolved Hide resolved
@gbotrel gbotrel merged commit b2b2ddd into master Sep 13, 2024
6 checks passed
@gbotrel gbotrel deleted the feat/csv_stats branch September 13, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub ivokub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbotrel @ivokub