Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Remove flattened contracts #640

Merged
merged 18 commits into from
Feb 4, 2025
Merged

Conversation

kyzooghost
Copy link
Contributor

@kyzooghost kyzooghost commented Jan 31, 2025

This PR implements issue(s) #632

Changelog

  • Removed flattened contracts with fixed pragmas
  • Removed contract upgrade tests using above flattened contracts, replace with placeholder comments
  • Add artifacts representing production deployments
  • Add versions to TokenBridge and L2MessageService build artifacts and deploy scripts

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@kyzooghost kyzooghost requested a review from a team as a code owner January 31, 2025 00:09
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e January 31, 2025 00:10 — with GitHub Actions Inactive
IntegrationTestTrueVerifier.sol
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.37%. Comparing base (1a811f4) to head (fe3f6bd).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #640      +/-   ##
============================================
- Coverage     68.39%   68.37%   -0.03%     
- Complexity     1181     1182       +1     
============================================
  Files           323      323              
  Lines         13125    13125              
  Branches       1316     1316              
============================================
- Hits           8977     8974       -3     
- Misses         3595     3598       +3     
  Partials        553      553              
Flag Coverage Δ
hardhat 98.52% <ø> (-0.43%) ⬇️
kotlin 66.02% <ø> (+<0.01%) ⬆️

see 2 files with indirect coverage changes

@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e January 31, 2025 01:08 — with GitHub Actions Inactive
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e January 31, 2025 01:16 — with GitHub Actions Inactive
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e January 31, 2025 02:39 — with GitHub Actions Inactive
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e January 31, 2025 02:57 — with GitHub Actions Inactive
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e January 31, 2025 03:30 — with GitHub Actions Inactive
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e February 3, 2025 12:10 — with GitHub Actions Inactive
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e February 3, 2025 12:23 — with GitHub Actions Inactive
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e February 4, 2025 07:17 — with GitHub Actions Inactive
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e February 4, 2025 09:30 — with GitHub Actions Inactive
@kyzooghost kyzooghost merged commit 5fbd7ed into main Feb 4, 2025
24 checks passed
@kyzooghost kyzooghost deleted the feat/remove-flattened-contracts branch February 4, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants