Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover/limitless backend job definitions #646

Draft
wants to merge 27 commits into
base: prover/limitless-top-level
Choose a base branch
from

Conversation

srinathln7
Copy link
Contributor

@srinathln7 srinathln7 commented Feb 3, 2025

This initial PR draft implements

  • Introduction of new jobs (sub-jobs) to support the functioning of Limitless prover with the existing JobDefinitions. See here
  • Unit tests to check and ensure that the naming convention of these files is respected by the file-watcher.
  • A basic mock simulating the creation of dummy proofs.
  • Fixes minor typo and adjusts code to eliminate trivial warnings.

Once we agree on the proposed job definitions, we can change the necessary configs and controller logics to execute these jobs.

@srinathln7 srinathln7 self-assigned this Feb 3, 2025
Copy link

cla-assistant bot commented Feb 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Feb 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.49%. Comparing base (fb4ee00) to head (6861e91).
Report is 4 commits behind head on prover/limitless-top-level.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             prover/limitless-top-level     #646   +/-   ##
=============================================================
  Coverage                         68.49%   68.49%           
  Complexity                         1130     1130           
=============================================================
  Files                               321      321           
  Lines                             12842    12842           
  Branches                           1287     1287           
=============================================================
  Hits                               8796     8796           
  Misses                             3506     3506           
  Partials                            540      540           
Flag Coverage Δ *Carryforward flag
hardhat 98.74% <ø> (ø)
kotlin 66.05% <ø> (ø) Carriedforward from f0de708

*This pull request uses carry forward flags. Click here to find out more.

@srinathln7
Copy link
Contributor Author

Update: All unit tests existing and new (for limitless prover job definitions) with the modified job definitions are working sucessfully. Actual controller, filewatcher implementation for limitless prover pending.

@srinathln7 srinathln7 removed the request for review from Soleimani193 February 6, 2025 15:03
@srinathln7 srinathln7 requested a deployment to docker-build-and-e2e February 6, 2025 15:04 — with GitHub Actions Waiting
@AlexandreBelling AlexandreBelling added the Prover Tag to use for all work impacting the prover label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants