feat: Report rejected transactions to an external service for SimulationValidator used by LineaTransactionPoolValidatorPlugin #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usmansaleem
changed the title
fab-10
reviewed
Sep 30, 2024
| paramLabel = "<NODE_TYPE>", | ||
| description = | ||
| "Linea Node type to use when reporting rejected transactions. (default: ${DEFAULT-VALUE}. Valid values: ${COMPLETION-CANDIDATES})") | ||
| private LineaNodeType lineaNodeType = LineaNodeType.SEQUENCER; |
There was a problem hiding this comment.
not sure is safe to set the default, I think it is better to default to something like UNSET or fail fast
There was a problem hiding this comment.
Sure, UNSET seems ok to me as well.
Comment on lines
+101
to
+117
| final String reason = handleModuleOverLimit(transaction, moduleLimitResult); | ||
|
|
||
| // Report rejected transactions to the JSON-RPC manager | ||
| rejectedTxJsonRpcManager.ifPresent( | ||
| jsonRpcManager -> { | ||
| final String jsonRpcCall = | ||
| JsonRpcRequestBuilder.generateSaveRejectedTxJsonRpc( | ||
| jsonRpcManager.getNodeType(), | ||
| transaction, | ||
| Instant.now(), | ||
| Optional.empty(), // block number is not available | ||
| reason, | ||
| List.of()); | ||
| jsonRpcManager.submitNewJsonRpcCall(jsonRpcCall); | ||
| }); | ||
|
|
||
| return Optional.of(reason); |
There was a problem hiding this comment.
Seems like extracting this code as method is a good idea, since also the following calls are similar
Comment on lines
+91
to
+93
| new JsonRpcManager( | ||
| besuConfiguration.getDataPath(), lineaRejectedTxReportingConfiguration) | ||
| .start()); |
There was a problem hiding this comment.
what happens if the JsonRpcManager is started or stopped twice, since both plugins could be enabled at the same time?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Report rejected transactions to an external service for SimulationValidator used by LineaTransactionPoolValidatorPlugin
Introduced/updated following cli options (
LineaRejectedTxReportingCliOptions):--plugin-linea-rejected-tx-endpoint- Endpoint URI for reporting rejected transactions. Specify a valid URI to enable reporting.--plugin-linea-node-type- Linea Node type to use when reporting rejected transactions. (default: SEQUENCER. Valid values: SEQUENCER,P2P,RPC)