Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use required plugins in ATs to not register tracer plugins #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −10
Open

Use required plugins in ATs to not register tracer plugins #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions acceptance-tests/src/test/java/linea/plugin/acc/test/BlockGasLimitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ public List<String> getTestCliOptions() {
@Override
@BeforeEach
public void setup() throws Exception {
minerNode = besu.createMinerNodeWithExtraCliOptions("miner1", getTestCliOptions());
cluster.start(minerNode);
super.setup();
minerNode.execute(minerTransactions.minerStop());
}

Expand Down
9 changes: 8 additions & 1 deletion acceptance-tests/src/test/java/linea/plugin/acc/test/LineaPluginTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,14 @@ private BesuNode createCliqueNodeWithExtraCliOptionsAndRpcApis(
.jsonRpcTxPool()
.genesisConfigProvider(
validators -> Optional.of(provideGenesisConfig(validators, cliqueOptions)))
.extraCLIOptions(extraCliOptions);
.extraCLIOptions(extraCliOptions)
.requestedPlugins(
List.of(
"LineaExtraDataPlugin",
"LineaEstimateGasEndpointPlugin",
"LineaSetExtraDataEndpointPlugin",
"LineaTransactionPoolValidatorPlugin",
"LineaTransactionSelectorPlugin"));

return besu.create(nodeConfBuilder.build());
}
Expand Down
7 changes: 0 additions & 7 deletions acceptance-tests/src/test/java/linea/plugin/acc/test/TestCommandLineOptionsBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,6 @@ public TestCommandLineOptionsBuilder() {
cliOptions.setProperty(
"--plugin-linea-l1l2-bridge-contract=", "0x00000000000000000000000000000000DEADBEEF");
cliOptions.setProperty("--plugin-linea-l1l2-bridge-topic=", "0x123456");
// temporarily specify tracer mandatory options, until we improve the ATs to accept a list of
// enabled plugins
cliOptions.setProperty("--plugin-linea-conflated-trace-generation-traces-output-path=", ".");
cliOptions.setProperty("--plugin-linea-rpc-concurrent-requests-limit=", "1");
cliOptions.setProperty("--plugin-linea-tracer-readiness-server-port=", "1234");
cliOptions.setProperty("--plugin-linea-tracer-readiness-server-host=", "localhost");
cliOptions.setProperty("--plugin-linea-tracer-readiness-max-blocks-behind=", "1");
}

public TestCommandLineOptionsBuilder set(String option, String value) {
Expand Down
Loading